1944150 - Update libcubeb to revision 2816b5a

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task)

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Bug 1944150 - Update libcubeb to revision 2816b5a. r?#cubeb-reviewers

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Bug 1944150 - Reapply local libcubeb patches. r?#cubeb-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/842c3707c2f9
Update libcubeb to revision 2816b5a.  r=cubeb-reviewers,pehrsons
https://hg.mozilla.org/integration/autoland/rev/9fe386800318
Reapply local libcubeb patches.  r=cubeb-reviewers,pehrsons

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/842c3707c2f9
https://hg.mozilla.org/mozilla-central/rev/9fe386800318

Comment 6

[Matthew Gregan [:kinetik]]

Attachment: Bug 1944150 - Remove WASAPI stream shutdown timeout. r?#cubeb-reviewers

Comment 7

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Potential UAF when destroying audio streams
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Difficult to reproduce reliably without using a debugger to delay thread shutdown
• Risk associated with taking this patch: very low
• Explanation of risk level: Converts shutdown from arbitrary timeout to blocking, removing the risk of stream shutdown completing after the timeout had expired
• String changes made/needed: none
• Is Android affected?: no

Comment 8

[Matthew Gregan [:kinetik]]

Attachment: Bug 1944150 - Remove WASAPI stream shutdown timeout. r?#cubeb-reviewers

Comment 9

[Phabricator Automation]

esr115 Uplift Approval Request

• User impact if declined: Potential UAF when destroying audio streams
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Difficult to reproduce reliably without using a debugger to delay thread shutdown
• Risk associated with taking this patch: very low
• Explanation of risk level: Converts shutdown from arbitrary timeout to blocking, removing the risk of stream shutdown completing after the timeout had expired
• String changes made/needed: none
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/fbbb63b89358

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/d1fc468b22bf