Closed Bug 1944156 Opened 26 days ago Closed 21 days ago

[wpt-sync] Sync PR 50318 - [Gap Decorations]: Setup paint for simple gap cases

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50318 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50318
Details from upstream follow.

Sam Davis Omekara (from Dev Box) <samomekarajr@microsoft.com> wrote:

[Gap Decorations]: Setup paint for simple gap cases

This CL uses the gap geometry from crrev.com/c/6092603 to paint gap
decorations within grid. The change begins by introducing a
ShouldPaintGapDecorations method in the BoxDecorationData class.
This method affects the ShouldPaint method, ensuring that gap
decorations are painted when necessary.

Next, two methods, PaintColumnGaps and PaintRowGaps, are
implemented in the BoxFragmentPainter class. These methods use the
stored offsets to construct rects, which are passed to appropriate
paint ops.

Future changes will preliminarily handle row fragmentation and
update the painting logic to use gap intersection pairs, as outlined in
the spec: https://drafts.csswg.org/css-gaps-1/#break.

Bug: 357648037
Change-Id: I87911c3da7a61562ce5126e396684902de5a1b73
Reviewed-on: https://chromium-review.googlesource.com/6101656
WPT-Export-Revision: df5a10d59e38e5a01b1126ce493da75ae43e8657

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests

Status Summary

Firefox

FAIL : 5

Chrome

FAIL : 5

Safari

CRASH: 1
FAIL : 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0dd20084939d [wpt PR 50318] - [Gap Decorations]: Setup paint for simple gap cases, a=testonly https://hg.mozilla.org/integration/autoland/rev/52dda8967ae0 [wpt PR 50318] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0dd20084939d
https://hg.mozilla.org/mozilla-central/rev/52dda8967ae0

Status: NEW → RESOLVED
Closed: 21 days ago
: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.