1944172 - Trigger biometric prompt when switching to PBM from the tabs tray

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, task)

Description

[:Gela]

Update the existing private browsing entry points to trigger the biometric prompt when the user enters private browsing mode from the tabs tray using the biometrics library under Android Components.

Point of entry: handleTrayScrollingToPosition()

https://searchfox.org/mozilla-central/source/mobile/android/android-components/components/lib/auth/src/main/java/mozilla/components/lib/auth

Comment 1

[:Gela]

Attachment: WIP: Bug 1944172 - Trigger Biometric Prompt for Private Tabs

Comment 2

[:Gela]

Attachment: Bug 1944172 - Trigger biometric pompt when switching to PBM from the tabs tray

Comment 3

[:Gela]

Attachment: WIP: Bug 1944172 - Add tests for trigger biometric pompt when switching to PBM from the tabs tray

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8757731c1e9
Trigger biometric pompt when switching to PBM from the tabs tray r=android-reviewers,twhite

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e8757731c1e9

Comment 6

[twhite]

Attachment: Bug 1944172 - Part 1: Add tests for TabsTrayFragment.kt shouldShowPrompt function.

Comment 7

[twhite]

Attachment: Bug 1944172 - Part 2: Add tests for TabsTrayFragment.kt onTabPageClick function. Includes refactor to move BiometricUtils into an interface to enable simpler testing

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0f95473713f
Part 1: Add tests for TabsTrayFragment.kt shouldShowPrompt function. r=android-reviewers,gmalekpour

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b0f95473713f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f21309322ab7
Part 2: Add tests for TabsTrayFragment.kt onTabPageClick function. Includes refactor to move BiometricUtils into an interface to enable simpler testing r=android-reviewers,mavduevskiy

Comment 12

[twhite]

Attachment: Bug 1944172 - Part 3: Refactor DefaultBiometricUtils from class to object

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50d3d8fc2299
Remove unnecessary whitespace CLOSED TREE

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae9b2db4a59a
Part 3: Refactor DefaultBiometricUtils from class to object r=android-reviewers,marcin

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f21309322ab7
https://hg.mozilla.org/mozilla-central/rev/50d3d8fc2299
https://hg.mozilla.org/mozilla-central/rev/ae9b2db4a59a