1944211 - RFPTarget PointerEvents mozPressure not compat

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Thorin [:thorin]]

In Bug 1871789 we closed some RFP pointer event leaks, but failed to make mozPressure behave same as a real mouse and the same as pressure - this is not an entropy issue, as all RFP users are the same, but would be nice to be smarter about things and match real world

https://arkenfox.github.io/TZP/tests/pointerevent.html

• pointer events are: [down|enter|leave|move|over|out|up]
• mdn: https://developer.mozilla.org/en-US/docs/Web/API/Pointer_events#active_buttons_state

non-rfp mouse

          pressure: 0.5 | 0 | 0 | 0 | 0 | 0 | 0
       mozPressure: 0.5 | 0 | 0 | 0 | 0 | 0 | 0

rfp mouse [edit: to be clear, if the value is the same for all events, it only writes it once]

          pressure: 0.5 | 0 | 0 | 0 | 0 | 0 | 0
       mozPressure: 0.5

Comment 1

[Thorin [:thorin]]

This would be nice to have for the next ESR. We have Bug 1534199 but it's going to take years to deprecate this, and this bug is triggering me and making me sad. Should be a simple IMO (but I'm not the engineer)

Comment 2

[Fatih Kilic [:fkilic]]

Attachment: Bug 1944211: Match PointerEvents's implementation for mozPressure. r?tjr

Comment 3

[Pier Angelo Vendrame]

Clearing the NI since Fatih self-assigned this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f77149613802
Match PointerEvents's implementation for mozPressure. r=tjr

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f77149613802

Comment 6

[Thorin [:thorin]]

verified fixed in Nightly 138. Is it possible to backport this to ESR128, thanks :)

Comment 7

[Fatih Kilic [:fkilic]]

Attachment: Bug 1944211: Match PointerEvents's implementation for mozPressure. r?tjr

Original Revision: https://phabricator.services.mozilla.com/D242931

Comment 8

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: ResistFingerprinting users will have a non-compat moz-pressure value
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Visit https://arkenfox.github.io/TZP/tests/pointerevent.html, verify pressure and moz-pressure matches
• Risk associated with taking this patch: None
• Explanation of risk level: None because we are just matching an already existing behaviour to another property, and only for resistfingerprintingprotection users
• String changes made/needed: No
• Is Android affected?: yes

Comment 9

[Fatih Kilic [:fkilic]]

Requested it

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/000b05df62ce