194423 - dd-* code cleanup

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

it looks like the following XUL atoms are no longer used:

XUL_ATOM(ddDropLocation, "dd-droplocation")
XUL_ATOM(ddDropLocationCoord, "dd-droplocationcoord")
XUL_ATOM(ddDropOn, "dd-dropon")
XUL_ATOM(ddTriggerRepaintSorted, "dd-triggerrepaintsorted")
XUL_ATOM(ddTriggerRepaintRestore, "dd-triggerrepaintrestore")
XUL_ATOM(ddTriggerRepaint, "dd-triggerrepaint")
XUL_ATOM(ddNoDropBetweenRows, "dd-nodropbetweenrows")

and maybe:

XUL_ATOM(ddDragDropArea, "dragdroparea")

here's the few places that use them:

/mailnews/addrbook/resources/content/abMailListDialog.js, line 527 --
rowGroup.setAttribute ( "dd-triggerrepaint", 0 );

and:

/xpfe/components/bookmarks/resources/bookmarksDD.js, line 136 --
rowGroup.setAttribute("dd-triggerrepaint" +
/xpfe/components/bookmarks/resources/bookmarksDD-temp.js, line 182 --
rowGroup.setAttribute ( "dd-triggerrepaintsorted", 0 );
/xpfe/components/bookmarks/resources/bookmarksDD-temp.js, line 184 --
rowGroup.setAttribute ( "dd-triggerrepaint", 0 );

jan tells me that bookmarksDD.js and bookmarksDD-temp.js are no longer used.

this bug just tracks the cleanup of this old code.

Comment 1

[Jan Varga [:janv]]

Nominating.
I can do this as a part of architecture changes we plan to do for bookmarks.

Comment 2

[Jan Varga [:janv]]

The bookmarks branch has landed.
Fixed.

Comment 3

[Chris Petersen]

Verified per last comments.