1944275 - Try to spellcheck less and optimize spellchecking in testcase of Bug 1943746

Status: NEW

(Core :: Spelling checker, enhancement)

Description

[Mayank Bansal]

https://bugzilla.mozilla.org/show_bug.cgi?id=1943746#c12

Here is a partial profile for 10x the testcase 1500000 elements:
https://share.firefox.dev/3PR3nIZ

This is the breakdown:

Actual generation: 4.8s
Reflow: 5.3s.
Spellcheck stuff: 53s (partial)

Emilio in https://bugzilla.mozilla.org/show_bug.cgi?id=1943746#c14

I think it's worth filing a bug for the spellcheck stuff... At the very least to try to spellcheck less (Bug 1943746#c6), but also there's some low hanging fruilt there (e.g. it seems mRealWords could benefit from being an AutoTArray, etc).

Looks like there is some optimization that is possible.
Ni? Emilio

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Do you know who owns spell-checking masayuki? Alternatively do you have strong opinions on bug 1943746 comment 6? Should we spell-check only once focused?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Unfortunately, nobody owns spell-checking. Makoto-san is probably more familiar with it than me, but I guess he also does not know 100% of the module.

About UX of the spell-checking, it must be that you are better than me because Japanese people does not use spellchecker at inputting text because Japanese word boundaries are not clear (not separated with white-spaces).

However, I think that even if it's more useful to keep current behavior, the running timing of the spellchecker is probably too eagerly. It shouldn't be required to be done so faster, but done at running benchmarks.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Olli has also reviewed code in this area so cc'ing for visibility.

I personally think that spellchecking only when focused is fine. You want to spellcheck when you're writing, usually. If you have editable content that hasn't ever been focused, you probably didn't write it :)

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

I personally think that spellchecking only when focused is fine. You want to spellcheck when you're writing, usually. If you have editable content that hasn't ever been focused, you probably didn't write it :)

I worry about restored content by the webapp, e.g., when user starts editing saved data. Then, there may be misspelled words in non-focused editor which the user thought they will correct them before sending the data outside.

Comment 5

[Jens Stutte [:jstutte]]

Unfortunately, nobody owns spell-checking.

That is not entirely true, at least it is part of our triage queue. But we do not have much work ongoing here.