Closed Bug 1944379 Opened 11 months ago Closed 11 months ago

[wpt-sync] Sync PR 50344 - Replace assert_notreached with assert_unreached

Tracking

()

Status:

RESOLVED FIXED

Milestone:

136 Branch

Tracking Flags:

Tracking

Status

firefox136

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

11 months ago

Sync web-platform-tests PR 50344 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50344
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Replace assert_notreached with assert_unreached

The former doesn't exist, while the latter does. No functional
change, other than a better error message if these conditions
get hit.

Change-Id: I445fdfea20afcf8d40100b898e1bc9b860377247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6206916
Reviewed-by: Di Zhang \<dizhangg@chromium.org>
Commit-Queue: Mason Freed \<masonf@chromium.org>
Auto-Submit: Mason Freed \<masonf@chromium.org>
Commit-Queue: Di Zhang \<dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1412390}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

11 months ago

Component: web-platform-tests → DOM: Core & HTML

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

11 months ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7fba28cae0e210b7db69758cf2b418a4282342a

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

11 months ago

Depends on: 1944632

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

11 months ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 249 subtests

Status Summary

Firefox

OK : 2
PASS: 186
FAIL: 81

Chrome

OK : 2
PASS: 267

Safari

OK : 2
PASS: 186
FAIL: 81

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/interactive-elements/the-dialog-element/dialog-closedby.html [wpt.fyi]
- closedby=any, Non-modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=any, Modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=closerequest, Non-modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=closerequest, Modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=none, Non-modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=none, Modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=AnY, Non-modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=AnY, Modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=ClOsErEqUeSt, Non-modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=ClOsErEqUeSt, Modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=NoNe, Non-modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=NoNe, Modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=invalid, Non-modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=invalid, Modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=, Non-modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=, Modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=null, Non-modal: FAIL (Chrome: PASS, Safari: FAIL)
- closedby=null, Modal: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/popovers/popover-attribute-basic.html [wpt.fyi]
- Changing attribute values should close open popovers: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to hint (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to manual (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to invalid (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to null (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to undefined (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to auto (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via attr), and then auto during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via attr), and then manual during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via attr), and then invalid during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via attr), and then null during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via attr), and then undefined during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via attr), and then auto during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via attr), and then manual during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via attr), and then invalid during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via attr), and then null during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via attr), and then undefined during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to null (via attr), and then auto during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to null (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to null (via attr), and then manual during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to null (via attr), and then invalid during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to null (via attr), and then null during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to null (via attr), and then undefined during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to undefined (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to auto (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via attr), and then auto during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via attr), and then manual during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via attr), and then invalid during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via attr), and then null during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via attr), and then undefined during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to undefined (via attr), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to hint (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to manual (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to invalid (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to null (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from auto to undefined (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to auto (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via idl), and then auto during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via idl), and then manual during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via idl), and then invalid during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via idl), and then null during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to manual (via idl), and then undefined during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via idl), and then auto during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via idl), and then manual during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via idl), and then invalid during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via idl), and then null during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to invalid (via idl), and then undefined during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to null (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from hint to undefined (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to auto (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via idl), and then auto during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via idl), and then manual during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via idl), and then invalid during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via idl), and then null during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to hint (via idl), and then undefined during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to null (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)
- Changing a popover from manual to undefined (via idl), and then hint during 'beforetoggle' works: FAIL (Chrome: PASS, Safari: FAIL)

Pulsebot

Comment 3

•

11 months ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1d537ba0210 [wpt PR 50344] - Replace assert_notreached with assert_unreached, a=testonly

Serban Stanca [:SerbanS]

Comment 4

•

11 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/d1d537ba0210

Status: NEW → RESOLVED

Closed: 11 months ago

status-firefox136: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 136 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 50344 - Replace assert_notreached with assert_unreached

Categories

(Core :: DOM: Core & HTML, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Updated

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Comment 3

Comment 4