1944380 - [wpt-sync] Sync PR 50345 - Reapply "Fix OptionList iterating before beginning"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50345 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50345
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Reapply "Fix OptionList iterating before beginning"

The new test in the original patch was failing on a Linux UBSan bot,
which revealed that OptionListIterator::operator*() was dereferencing a
null element. I fixed this by adjusting the test and adding a DCHECK to
make sure the element is not null before dereferencing. I also added a
WPT to make sure that the DCHECK doesn't get hit.

This reverts commit 3bef4696dcb69725d3f1c72a0984ba91c2e00056.
Original patch: commit 505729eedfd6243a6520d9fd09012b5dde449511

Fixed: 388299752
Change-Id: I01712fec0479ca567121051b33e6478cf77818b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203424
Commit-Queue: Traian Captan \<[e-mail]>
Auto-Submit: Joey Arhar \<[e-mail]>
Reviewed-by: Traian Captan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1412393}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa2ca6048404ccf89ff756a9a9a56087ab34b823

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/customizable-select/select-iterate-before-beginning.tentative.html [wpt.fyi]
  • Attempting to focus the previous option while focused on the first option should not crash.: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a10a36d498f
[wpt PR 50345] - Reapply "Fix OptionList iterating before beginning", a=testonly
https://hg.mozilla.org/integration/autoland/rev/100125ffeb44
[wpt PR 50345] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5a10a36d498f
https://hg.mozilla.org/mozilla-central/rev/100125ffeb44