1944505 - Simple Tab Groups keeps crashing on Nightly 136.0a1 when creating and moving groups

Status: RESOLVED MOVED

(WebExtensions :: Developer Outreach, defect)

Description

[Alex Cornestean]

Attachment: screenshots-STG.png

[Affected versions]:
Nightly - 136.0a1/20250128161837

[Description]:
Creating a new group via the extension pop up will cause the extension to crash.
Nightly will display notifications stating that something went wrong and when clicking the notification will open a new window with the extension debug page. Closing the debug page will restart the extension with no further crashes occurring.
Creating further groups or moving groups (via drag and drop) in the extension pop up will crash the extension again.

Attached is a console log detailing what occurs when creating a group, the extension crashing, the extension restarting, creating a new group and moving groups.

[Steps to reproduce]:

1. Install Simple Tab Groups v 5.2 from https://addons.mozilla.org/en-US/firefox/addon/simple-tab-groups/
2. Pin the extension button to the toolbar (although the issue occurs even when the extension button is not pinned to the toolbar)
3. Open the extension pop up and click on “Create new group”
4. As soon as the new group is created with the desire name, the extension will crash (multiple times it seems), with the following behavior occurring:

• the name of the newly created group in the extension pop-up will change to contain which appear to be debug strings. For example, “Group 2” will change to “@3:#2 Group 2”. See attached screenshot

NOTE: This is most likely due to debug mode being enabled automatically on extension crash.

• Nightly will show a notification, stating “Simple Tab Groups / What’s wrong… / Please notify the developer by support email with last error logs…”. See attached screenshot.

NOTE 1: Trying to close the notification will at first dismiss it as expected, however immediately after dismissal a new notification is displayed
NOTE 2: Switching focus to another opened window in the OS and then switching back to Nightly will also trigger the display of the notification

5. Click the notification
6. Notice a new browser window is opened with the extension debug page. See attached screenshot
7. Click on the “Close” button to close the debug page
8. Notice the extension restarts after the debug page is closed (noticeable from a throbber appearing where the extension icon is)
9. Switch focus to another window and then switch back to Nightly. Notice the notification is no longer triggered
10. Open the extension pop up and notice the name of the created group no longer contains debug characters.
11. Create a new group as detailed in Steps 3 & 4. Notice the extension crashes again
12. Perform Steps 5 to 8 once more so the extension restarts
13. Open the extension pop up and drag and drop one group above another group to move it. Notice the extension crashes again

[Expected]:
The extension should function properly without crashing when creating and moving groups.

[Actual]:
The extension crashes when creating and moving groups.

[Regression range]:

2025-01-29T11:32:35.580000: DEBUG : Found commit message:
Bug 1688743 - Make menus.update and menus.remove throw when menu item is not found. r=robwu

Differential Revision: https://phabricator.services.mozilla.com/D232166

2025-01-29T11:32:35.581000: DEBUG : Did not find a branch, checking all integration branches
2025-01-29T11:32:35.584000: INFO : The bisection is done.
2025-01-29T11:32:35.589000: INFO : Stopped

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b8b948612acb56730316f0f329b03a3af18e51da&tochange=2c5db6ac9fcb3ca4e828d6b7ff76aa196ff39bb5

Comment 1

[Alex Cornestean]

Attachment: console-export-2025-1-29_11-11-36.txt

Comment 2

[Rob Wu [:robwu]]

Thanks for identifying the regression range. I forwarded this report and actionable details to the STG devs at https://github.com/Drive4ik/simple-tab-groups/issues/1242#issuecomment-2621175808

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1688743

:kernp25, since you are the author of the regressor, bug 1688743, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Rob Wu [:robwu]]

I have already reached out to the STG devs at https://github.com/Drive4ik/simple-tab-groups/issues/1242#issuecomment-2621175808

If there is more fallout, we can consider putting some or all of the changes behind a pref.

Comment 6

[Alex Cornestean]

A new version of the STG extension (5.3) with a fix is currently being reviewed and will soon be released on AMO.

In the meantime, an un-official provisional version of STG with the fix is available at https://github.com/Drive4ik/simple-tab-groups/issues/1242#issuecomment-2644517626 , which I tested on the latest Nightly (137.0a1/20250224170755) and Beta (136.0b9/20250221091531) under Windows 10 to confirm the fix.

The version with the fix works as expected, no longer crashing when creating groups or moving them.