1944519 - Saw callout for how to restore closed tab groups when no group was created

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect)

Description

[Dave Townsend [:mossop]]

I just did the following steps:

1. Drag a tab in the vertical tabs over another tab to create a group.
2. That was an accident so in the tab creation popup I clicked cancel.
3. I then saw a callout appear over the all tabs button saying something like "Tab groups you have closed are available here".

I didn't really close the tab group, I cancelled its creation. As expected the group does not appear in the all tabs menu but I think it is confusing to show the callout in this case.

Comment 1

[Dão Gottwald [:dao]]

Hmm, this should be using the TabGroupCreateDone event which should only be dispatched when the group creation was confirmed. Emily, are you getting the event when hitting cancel, or is something else wrong here?

Comment 2

[Emily McMinn :emcminn]

The ASRouter trigger is indeed listening for TabGroupCreateDone - I'll see if I can catch it firing somewhere it's not supposed to.

EDIT: So I do consistently see the callout rendering if I press 'esc' before naming a tab group, or when hitting the cancel button. Looks like that's firing TabGroupRemoved, which we are also listening for (the save/close version of the callout is what's being shown.)

Comment 3

[Emily McMinn :emcminn]

This should now be fixed by bug 1944103, so I'm going to close this bug. Feel free to reopen if needed :)