1944565 - Add the --remote-enable-system-access argument to Firefox to control whether the client is allowed to access the parent process

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On bug 1359472 we are adding a --enable-system-access argument to geckodriver, which is forwarding it to Firefox as a --remote-enable-system-access argument. This argument is needed for Firefox because WebDriver BiDi clients can connect directly to Firefox without running the HTTP-upgrade path.

The argument’s value will be evaluated by the RemoteAgent and exposed as a property on the RemoteAgent interface in the parent process. Both WebDriver BiDi and Marionette will access this property in the future to determine whether system access is enabled. Based on this value, they will allow or disallow interaction with browsing contexts in the parent process or privileged sandboxes in content processes.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Freddy, based on my latest comments on bug 1359472 I wonder if this bug should be as well a security one or if a confidential is already enough. See my initial description what we are planning to do for both Marionette and WebDriver BiDi. For adding this argument to Firefox do we need another security review here or on bug 1710425 or for WebDriver BiDi bugs like bug 1944568 (there will be more for individual commands). Thanks!

Comment 2

[Frederik Braun [:freddy]]

Confidential is fine

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1944565 - [remote] Add "--remote-allow-system-access" command line argument to Firefox.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f97b598e8b82
[remote] Add "--remote-allow-system-access" command line argument to Firefox. r=webdriver-reviewers,Sasha

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing wpt & lint failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3e7d2dc07f55d2df2e18cc6cf6c0ac032c9ddfa6

Push with failures

Failure log lint failure #1

Failure log lint failure #2

Failure log wpt

Failure log bc

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The failures are related to the addition / changes on bug 1710425.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d32bcd1ce40
[remote] Add "--remote-allow-system-access" command line argument to Firefox. r=webdriver-reviewers,Sasha

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30641a3b843c
Backed out 10 changesets (bug 1944565, bug 1710425) for causing multiple failures CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/befe2d20cf40
[remote] Add "--remote-allow-system-access" command line argument to Firefox. r=webdriver-reviewers,Sasha

Comment 10

[agoloman]

Backed out for causing failures @test_no_errors_clean_profile.py.

• Backout link
• Push with failures
• Failure Log

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The problem here is that we also have to consume the command line argument in the nsICommandLineHandler:handle method, see bug 1838158 for details to the other arguments. I'm going to update the patch to include the new argument, which will fix the browser chrome test for me.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5d53ed10ea0
[remote] Add "--remote-allow-system-access" command line argument to Firefox. r=webdriver-reviewers,Sasha

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c5d53ed10ea0