1944570 - Support executing “script.evaluate” and “script.callFunction” for browsing contexts in the parent process

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

To support the evaluation of JavaScript in the parent process, the existing JSWindowActor implementation for the MessageHandler can be reused. No additional work is required because the actor can be enabled for Chrome by setting the includeChrome field in the actor configuration to true during registration.

This feature should only be taken into account when system access is enabled to avoid unintended side effects in the normal operational mode.
Once enabled, the JSWindowActor will automatically route IPC messages to the appropriate target BrowsingContext, whether it resides in the content or parent process.

Also we do not want to enable support for the parent process for all available WebDriver BiDi commands (particularly event subscriptions) at that point. So an additional internal flag will most likely be required. It can be passed by the two evaluation commands to the underlying MessageHandler to indicate that it is allowed to forward the command to the parent process. Commands that do not set this flag will be aborted with an "operation not supported" error when a browsing context of the parent process is referenced.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As discussed on Matrix I'm going to reduce the points for this bug because support for realms as target cannot be implemented yet because the message manager misses support for chrome browsing contexts. There is bug 1713440 to get the support added.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1944570 - [remote] Allow loading the MessageHandlerFrameActor for chrome scope.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1944570 - [remote] Only use the webprogress in the RootTransport module for content browsing contexts.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1944570 - [webdriver-bidi] Support executing “script.evaluate” and “script.callFunction” for chrome browsing contexts.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2be355c689d5
https://hg.mozilla.org/integration/autoland/rev/bb0c513026eb
[remote] Allow loading the MessageHandlerFrameActor for chrome scope. r=Sasha
https://github.com/mozilla-firefox/firefox/commit/dea83376f29e
https://hg.mozilla.org/integration/autoland/rev/0b8681969bab
[remote] Only use the webprogress in the RootTransport module for content browsing contexts. r=Sasha
https://github.com/mozilla-firefox/firefox/commit/bcad9346c1f3
https://hg.mozilla.org/integration/autoland/rev/55119776daff
[webdriver-bidi] Support executing “script.evaluate” and “script.callFunction” for chrome browsing contexts. r=Sasha

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bb0c513026eb
https://hg.mozilla.org/mozilla-central/rev/0b8681969bab
https://hg.mozilla.org/mozilla-central/rev/55119776daff