Closed Bug 1944641 Opened 24 days ago Closed 21 days ago

[wpt-sync] Sync PR 50372 - Fix ListedElement is focusable pre-check for host with delegatesFocus

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50372 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50372
Details from upstream follow.

Di Zhang <dizhangg@chromium.org> wrote:

Fix ListedElement is focusable pre-check for host with delegatesFocus

The function calls are as follow:
HTMLFormElement::reportValidity()
HTMLFormElement::ValidateInteractively()
ListedElement::ValidationAnchorOrHostIsFocusable()

This means a custom element inside a form element will call the above
functions to check validity of the form input and show the validation
message accordingly.

In ListedElement::ValidationAnchorOrHostIsFocusable, the function checks
whether the anchor element or the host is focusable. If the anchor is
specified, it checks the correct element. If not, it will check the
host. However, in the case of a custom element with delegatesFocus,
we should not check the host, but instead check its focusable area.

Change-Id: Ie331a17c3622ac949ce70cfcacbf035efd73ae89
Fixed: 389587444
Bug: 40726105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174381
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Di Zhang \<dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413006}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/962501bd8c46 [wpt PR 50372] - Fix ListedElement is focusable pre-check for host with delegatesFocus, a=testonly https://hg.mozilla.org/integration/autoland/rev/7ff56a829dc1 [wpt PR 50372] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 21 days ago
: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.