1944648 - Instrument a version of the profile group ID for the usage ping

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement, P2)

Description

[Leif Oines [:loines]]

Background

We have a new “usage reporting” ping that was instrumented as a minimal way to understand DAU.

This ping has a new profile-level ID, the usage_profile_id .This ID is distinct from both the glean-based client_id and the legacy telemetry-based client_id.

Our DAU counts are currently based on the number of unique profiles that are active per day.

For legacy and glean telemetry, there also exists a profile_group_id, which is a UUID shared by all profiles on a single instance of desktop Firefox (Details in Bug 1913765). Having this ID opens the door to switching our DAU counts to be based on be profile groups - rather than individual profiles - in the case that many new profiles are created by existing Firefox installs.

Request
Currently, there does not exist a profile group-level ID in the usage ping. We would like to add one to the usage ping so that it can also be used to count profile groups (if the need arises). We are proposing this be a new ID (usage_profile_group_id or similar) that would only be sent in the usage ping, and behave similarly to the existing profile_group_id but not be linkable/joinable to it within our data warehouse.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Pulling into our Jira just for tracking purposes. Open question here: would it make more sense for chutten / client data eng team to own this, and implement it while they're implementing the DAU ping?

Comment 2

[Leif Oines [:loines]]

The dau ping (now known as the "usage ping") is mostly done, we are collecting data from it already. It could be that a collaboration between your team and Alessio's team might make sense here, this is similar to how the usage ping was implemented.

The need for this is dependent on two things, namely (1) whether ToS compels to use the usage ping for DAU reporting, and (2) whether the profile management feature inflates DAU to such an extent that we need to start counting group_ids instead of client_ids. We'll have a good idea of (1) probably by april. (2) I guess depends on the rollout timeline for the profile management feature.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hey Leif, any updates on item (1) from your last comment?

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1944648 - Add Usage Profile Group ID to usage-reporting code. r?chutten!,loines,TravisLong

Comment 5

[Leif Oines [:loines]]

(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #3)

Hey Leif, any updates on item (1) from your last comment?

Sorry for the slow reply - I think Daniel may have talked with you already... but, yes while we haven't definitely made a decision on the KPIs yet, given the data as it is now there is definitely a decent chance for us to switch to the usage ping. So doing this work now definitely makes sense

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e274006a32d
Add Usage Profile Group ID to usage-reporting code. r=TravisLong,chutten,data-stewards

Comment 7

[Nneka]

Commenting on behalf of the sensitive data review team to confirm our approval (originally provided via email). Keeping this new ID unlikable/unjoinable to profile_group)_ID and limiting its purpose for only reporting are appropriate privacy mitigations. We also noted the importance of counting DAU accurately by profile/profile-group in the future and that profile ID is already shared with client_ID (outside of this request). Thanks to the team for checking in on this one.

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/1e274006a32d

Comment 9

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9481056 [details]
Bug 1944648 - Add Usage Profile Group ID to usage-reporting code. r?chutten!,loines,TravisLong

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This patch allows us to correct DAU overcounting of multiple profiles users by adding a "usage profile group ID" to the new DAU ping. We may be asked to release profiles to larger than 0.5% sooner than expected; this patch helps correct for DAU inflation if the feature is widely released and widely adopted.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The updated section of code has good automated test coverage, and the changes are straightforward.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please submit an approval request through Phabricator.

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

thank you!

Comment 12

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1944648 - Add Usage Profile Group ID to usage-reporting code. r?chutten!,loines,TravisLong

Original Revision: https://phabricator.services.mozilla.com/D246699

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: This patch allows us to correct DAU overcounting of multiple profiles users by adding a "usage profile group ID" to the new DAU ping. We may be asked to release profiles to larger than 0.5% sooner than expected; this patch helps correct for DAU inflation if the feature is widely released and widely adopted.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Verify that the usage profile group ID is added to the usage-reporting ping.
• Risk associated with taking this patch: Low
• Explanation of risk level: The updated section of code has good automated test coverage, and the changes are straightforward.
• String changes made/needed: None
• Is Android affected?: no

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/9f381f23d17a