194472 - "Product has no components" error should link to that product's component editor

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Dave Miller [:justdave]]

When you enter a new bug, and you choose a product that has no components in it,
you get an error message telling you there are not components defined in that
product.  If you have editcomponents privs, it also gives you a link to
editcomponents.cgi.  Except that it links to the main product list, so you have
to choose the product all over again (you just did that in order to get the
error message).  The error message should link directly to the component editor
for the product in question.

Comment 1

[Dave Miller [:justdave]]

The User Interface component now belongs to Gerv.  Reassigning all UNCONFIRMED
and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component
owner) to Gerv.

Comment 2

[Dave Miller [:justdave]]

Reassigning back to Myk.  That stuff about Gerv taking over the User Interface
component turned out to be short-lived.  Please pardon our confusion, and I'm
very sorry about the spam.

Comment 3

[chaduv]

I'll take this.

Comment 4

[chaduv]

Attachment: Link goes to the desired place

Pass in the product to the error message.

Comment 5

[Jouni Heikniemi]

Can you reproduce this in some version of Bugzilla? On CVS tip, the
enterable_products list never contains products without components, so I can't
come up with a situation that would even give that error message.

Comment 6

[Jouni Heikniemi]

Comment on attachment 134871 [details] [diff] [review]
Link goes to the desired place

>-      <a href="editcomponents.cgi">Create a new component</a>.
>+      <a href="editcomponents.cgi?product=[% product FILTER uri %]">Create a new component</a>.

Make it |FILTER url_quote|, and please wrap the line so that it doesn't exceed
80 chars (if you can).

Comment 7

[GavinS]

Note that the recent checkin for bug#228894 contained part of the fix for this patch. I had done 
the changes Jouni suggested, and that part of the fix sneaked into the patch for the other bug - 
sorry.

In bug#228894, I have asked for someone to either retract that part of the change, or apply the 
first part of this patch.

Comment 8

[Vlad Dascalu]

Attachment: Patch version 2

Chaduv's patch with jouni's suggestion.

Comment 9

[Vlad Dascalu]

Attachment: Patch version 3

Spliting it like this creates a blank space in the URL at the beginning.

Spliting instead at the first available space in the URL (the alternative would
be to insert a comment in the URL which seems like a dirty hack).

Comment 10

[Christian Reis]

Comment on attachment 140567 [details] [diff] [review]
Patch version 3

Cool!

Comment 11

[Vlad Dascalu]

Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.88; previous revision: 1.87
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.48; previous revision: 1.47
done