Closed Bug 1944728 Opened 1 year ago Closed 1 year ago

Don't fail on missing/empty SSH_PRIVATE_KEY

Categories

(Conduit :: Lando, defect)

Product:
Conduit
Component:
Lando
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: shtrom, Assigned: shtrom)

References

Details

Attachments

(1 file)

[mozilla-conduit/lando] worker: don't fail on ssh_private_key missing or empty in env (bug 1944728) (#212)
49 bytes, text/x-github-pull-request
Details | Review

The git landing worker doesn't need an SSH_PRIVATE_KEY (because it's only needed for HgMO). But the worker chokes on this because it will try to find a key to load https://github.com/mozilla-conduit/lando/blob/ce3f70a8bcacb9a77892dc4aa8b7ca355655baba/src/lando/api/legacy/workers/base.py#L61-L67, but even if the key is undefined, it will then try to load that https://github.com/mozilla-conduit/lando/blob/ce3f70a8bcacb9a77892dc4aa8b7ca355655baba/src/lando/api/legacy/workers/base.py#L125-L126And then sadness ensues.

Assignee: nobody → omehani
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: