1944794 - [wpt-sync] Sync PR 50379 - Allow custom properties in highlight pseudos

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50379 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50379
Details from upstream follow.

Stephen Chenney <[e-mail]> wrote:

Allow custom properties in highlight pseudos

This is a workaround for the use case of custom properties
defined and used in the same rule for ::selection pseudos.
The use case arises from tooling, particularly Tailwind CSS,
and it caused a stable regression when Highlight Inheritance
was launched.

This change restores the original behavior in that highlight
pseudos can use custom properties defined in the highlight
itself. The custom properties are not inherited through the
highlight inheritance chain, so this change does not result in
confusion about the source of custom properties when Highlight
Inheritance is enabled: the properties still come from the
originating element and then the highlight pseudo itself, never
it's parent highlight.

CSS Spec PR: https://github.com/w3c/csswg-drafts/pull/11528

Fixed: 381125910
Change-Id: I0f89e6b8ad96d097ce1e2b39c179a270d472991f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6053860
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Commit-Queue: Stephen Chenney \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1413271}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9bae0413dba03302f500e0e9852631b015c7191c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 2 subtests

Status Summary

Firefox

OK : 2
PASS: 9

Chrome

OK : 2
PASS: 5
FAIL: 4

Safari

OK : 2
PASS: 9

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dea018ee4fcb
[wpt PR 50379] - Allow custom properties in highlight pseudos, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4d20414e8102
[wpt PR 50379] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dea018ee4fcb
https://hg.mozilla.org/mozilla-central/rev/4d20414e8102