1944817 - The history tab is not displayed when long-pressing on Android back button

Status: VERIFIED FIXED

(Fenix :: History, defect)

Description

[Vasilica Tamas QA [:vtamas]]

Attachment: HistoryTabNotDisplayed.mp4

Steps to reproduce

1. Navigate to a website
2. Open several links in the same tab
3. Long-press the Android back button.

Expected behavior

The history panel shows up displaying the tab history.

Actual behavior

There is no history panel displayed.

Device information

• Firefox version: Firefox Nightly 136 (2025-01-29), Firefox RC 135, Firefox 134.0.2
• Android device model: Samsung Galaxy A32 (Android 13), Poco X6 Pro (Android 14)

Any additional information?

This is a follow-up issue for Bug 1932300.

Comment 1

[Bob]

This not working in Android 13 is expected, as the fix from bug 1932300 could only be applied to Android 14+. It not working on Poco with Android 14 is unexpected, however.

As mentioned in bug 1932300 comment 47 a potential solution for Android 13 is to gate the enableOnBackInvokedCallback feature flag to API34+ only, at the potential risk of reintroducing bug 1898059 so we may need to pick one of the two bugs to wontfix.

Nothing immediately comes to mind for fixing the Poco situation: the API used in bug 1932300 theoretically should work across all Android 14 devices so there must be something manufacturer-specific going on here. I'm not sure if it's a good idea to add yet another special case for this.

Comment 2

[Bob]

Attachment: Bug 1944817 - Use legacy back press handling on Android 13 r?#android-reviewers

Use alternative resources to only enable enableOnBackInvokedCallback
on Android 14+ (API34+)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2db9724555ea
Use legacy back press handling on Android 13 r=android-reviewers,petru

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2db9724555ea

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bob+bmo, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

We will probably want this uplifted as it's a small change which brings an important quality of life improvement for users
And I can help with that
After QA validates the improvement with no other negative impact.

Comment 7

[Bob]

If it's not too much trouble, please also retest bug 1898059 on Android 13 - I expect this to have effectively reintroduced that problem. If it has, do we just accept one or the other must exist?

Comment 8

[Vasilica Tamas QA [:vtamas]]

Attachment: BackButtonHistory.mp4

Tested this issue on Firefox Nightly 137 (2025-02-07) and it is fixed only on Samsung A32 (Android 13). Poxo X6 Pro (Android 14) device is still affected and I logged a separate issue Bug 1946778.

(In reply to Bob from comment #7)

If it's not too much trouble, please also retest bug 1898059 on Android 13 - I expect this to have effectively reintroduced that problem. If it has, do we just accept one or the other must exist?

Also retested this issue across several devices and we didn't noticed any regression caused by this fix. However, we did find an issue related to The History and Bookmarks pages where they close when swiping outside the result entries - Bug 1946777

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Given that the patch here is shown to fix the back button issue on Android 13 also
While the other issues are pre-existent and not directly caused by this
Seems like we should uplift this.

Comment 11

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9462838 [details]
Bug 1944817 - Use legacy back press handling on Android 13 r?#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This ensures long pressing on the back button shows the tab history on Android 13 also - the only Android version with the behaviour still broken.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
  1 - Long press the back button on an Android 13 device and check that the tab history is shown
  2 - While browsing tap the URL to enter search mode. Do a back button press or a back gesture and check that you are brought back to browsing.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change verified by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9462838 [details]
Bug 1944817 - Use legacy back press handling on Android 13 r?#android-reviewers

Approved for 136.0b5

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/849b6dbf9365

Comment 14

[Delia Pop (Android QA)]

Verified as fixed in Beta 136.0b5 with Nothing Phone (2a) 5G (Android 14) and Samsung GalaxyZ Fold 4 (Android 14).