1944835 - Unused object in PdfjsParent.sys.mjs

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Tooru Fujisawa [:arai]]

PdfjsParent.sys.mjs contains the following code, but the Svc variable is no longer used and it can be removed.

https://searchfox.org/mozilla-central/rev/dd8b64a6198ff599a5eb2ca096845ebd6997457f/toolkit/components/pdfjs/content/PdfjsParent.sys.mjs#39-45

var Svc = {};
XPCOMUtils.defineLazyServiceGetter(
  Svc,
  "mime",
  "@mozilla.org/mime;1",
  "nsIMIMEService"
);

Comment 1

[Henry Yeary]

Hey Tooru!

I'd be happy to make this simple change.

I am still very new to the Firefox OSS community, so apologies if I make some newbie mistakes here and there when submitting the patch.

Comment 2

[Henry Yeary]

Attachment: Bug 1944835 - Remove unused Svc object and unused getter definition from PdfjsParent. r=arai

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a82bfb869b9d
https://hg.mozilla.org/integration/autoland/rev/590c80335aed
Remove unused Svc object and unused getter definition from PdfjsParent. r=arai,calixte

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/590c80335aed