1944988 - [wpt-sync] Sync PR 50397 - Need to check style before inert attribute for editability

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50397 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50397
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Need to check style before inert attribute for editability

If inert attribute is checked first, the effect of the interactivity
property will be ignored. Even without interactivity support, the style
includes the effect of the inert attribute as IsInert->IsHTMLInert on
ComputedStyle affects the used value of user-modify.

The added test currently does not pass because the inert attribute still
forces html inertness in the subtree.

Bug: 370065759
Change-Id: I318f56237f5e210084fec836dac88b0773354023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6217065
Commit-Queue: Rune Lillesveen \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1413788}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=81c867e82e93e3b318bc82f7dd82ca6ed2160661

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 1

Chrome

OK : 1
PASS: 2
FAIL: 1

Safari

OK : 1
PASS: 2
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /inert/inert-node-is-uneditable.html [wpt.fyi]
  • Can edit interactivity:auto contenteditable inside inert: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23b95f52c253
[wpt PR 50397] - Need to check style before inert attribute for editability, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8addafc4f06d
[wpt PR 50397] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/23b95f52c253
https://hg.mozilla.org/mozilla-central/rev/8addafc4f06d