1944993 - Lock icon of error page for empty error response codes doesn't reflect security status

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Manuel Bucher [:manuel]]

Clicking on the lock icon in the url bar. Then on

Connection failure

the text reads:

(i) You are not securely connected to this site.

Your connection to this site is not private. Information you submit could be viewed by others (like passwords, messages, credit cards, etc.).

Which contradicts with information from devtools. The connection security details apparently currently don't propagate to the lock icon for some reason.

Comment 1

[Sean Kim [:sekim]]

Don't think this bug blocks Bug 1944358 since this is a common message for all neterror/certerror. Perhaps we need a mechanism to introduce different error messages for each error.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:valentin, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

(In reply to Manuel Bucher [:manuel] from comment #0)

Which contradicts with information from devtools. The connection security details apparently currently don't propagate to the lock icon for some reason.

I think previously it made sense for the lock not to be there - the error page appeared when there was a connection error, or cert error.
We now reuse it for a few other use cases like 1325876, where there's no actual error, so the security details would probably be useful to preserve.

Comment 4

[Sean Kim [:sekim]]

Attachment: Bug 1944993 - Block connection failure message for neterrors without connection error r=#necko

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a05cfb76d4fb
Block connection failure message for neterrors without connection error r=necko-reviewers,valentin

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a05cfb76d4fb