1945002 - [wpt-sync] Sync PR 50399 - Change order of [inert] vs :modal UA style for interactivity

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50399 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50399
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Change order of [inert] vs :modal UA style for interactivity

A fullscreen'ed element or modal dialog should still be inert if it has
an inert attribute. This keeps the existing behavior when the inert
attribute set html inertness.

The specificity is modified to ensure this behavior.

Additionally add an interactivity declaration for select buttons to
prepare for no longer setting html inertness for IsInertRoot().

The UA rule could have been implemented as :modal for both dialogs and
fullscreen elements, but that would have ended up in the universal
bucket for all elements for the dialog case.

Bug: 370065759
Change-Id: I5be974534abb6714cc964070cbf04437408a2a08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6216527
Reviewed-by: Mason Freed \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1413833}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fb884cb1593c5c5a52781d0bc7ce3604096b80c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 5 subtests

Status Summary

Firefox

OK : 2
FAIL: 10

Chrome

OK : 2
PASS: 4
FAIL: 6

Safari

OK : 2
FAIL: 10

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-ui/interactivity-inert-fullscreen-ua.html [wpt.fyi]
  • UA :fullscreen interactivity rule: FAIL (Chrome: PASS, Safari: FAIL)
  • UA [inert] rule wins over UA :fullscreen rule: FAIL (Chrome: FAIL, Safari: FAIL)
  • UA :fullscreen rule overriding inherited [inert] 'interactivity:inert' rule: FAIL (Chrome: FAIL, Safari: FAIL)
  • UA [inert] rule overriding inherited :fullscreen 'interactivity:auto' rule: FAIL (Chrome: FAIL, Safari: FAIL)
  • Author 'interactivity:inert' overrides UA :fullscreen 'interactivity:auto' rule: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-ui/interactivity-inert-modal-dialog-ua.html [wpt.fyi]
  • UA dialog:modal interactivity rule: FAIL (Chrome: PASS, Safari: FAIL)
  • UA [inert] rule wins over UA dialog:modal inert rule: FAIL (Chrome: FAIL, Safari: FAIL)
  • UA dialog:modal rule overriding inherited [inert] 'interactivity:inert' rule: FAIL (Chrome: FAIL, Safari: FAIL)
  • UA [inert] rule overriding inherited dialog:modal 'interactivity:auto' rule: FAIL (Chrome: FAIL, Safari: FAIL)
  • Author 'interactivity:inert' overrides UA dialog:modal 'interactivity:auto' rule: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b75ec103d3fa
[wpt PR 50399] - Change order of [inert] vs :modal UA style for interactivity, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d3e9a4e445fd
[wpt PR 50399] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b75ec103d3fa
https://hg.mozilla.org/mozilla-central/rev/d3e9a4e445fd