Closed Bug 1945016 Opened 24 days ago Closed 19 days ago

Remove quickSuggestAllowPositionInSuggestions and support for suggestion.position

Categories

(Firefox :: Address Bar, task, P3)

task

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

Attachments

(1 file)

This is part of some Suggest refactoring/cleanup I'd like to do.

I'm trying to improve how Suggest handles result.isBestMatch and suggestion.is_top_pick, and I bumped into our support for suggestion.position. We don't have any plans to use quickSuggestAllowPositionInSuggestions or browser.urlbar.quicksuggest.allowPositionInSuggestions, and IIRC we never used it, so I think we should remove it.

Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/80db4d684a64 Remove quickSuggestAllowPositionInSuggestions and support for suggestion.position. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 19 days ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
Blocks: 1946894
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: