1945020 - Update minimum Rust version to 1.82

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task, P1)

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1945020 - build(rust): bump minimum Rust version 1.76 → 1.82 r=glandium

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc6c49efcb3d
build(rust): bump minimum Rust version 1.76 → 1.82 r=glandium

Comment 3

[agoloman]

Backed out for causing build bustages.

• Backout link
• Push with failures
• Failure Log

To compile Rust language sources please install at least
[task 2025-01-31T03:16:42.073Z] 03:16:42     INFO -  version 1.82.0 of the 'rustc' toolchain (or, if using nightly,
[task 2025-01-31T03:16:42.073Z] 03:16:42     INFO -  at least one version newer than 1.82.0) and make sure it is
[task 2025-01-31T03:16:42.073Z] 03:16:42     INFO -  first in your path.
[task 2025-01-31T03:16:42.073Z] 03:16:42     INFO -  You can verify this by typing 'rustc --version'.
[task 2025-01-31T03:16:42.074Z] 03:16:42     INFO -  If you have the 'rustup' tool installed you can upgrade
[task 2025-01-31T03:16:42.074Z] 03:16:42     INFO -  to the latest release by typing 'rustup update'. The
[task 2025-01-31T03:16:42.074Z] 03:16:42     INFO -  installer is available from https://rustup.rs/

Comment 4

[Mike Hommey [:glandium]]

Oh, right, I forgot we're stuck on 1.81 for asan builds because our patch for -Z build-std doesn't apply to 1.82 and needs to be rewritten.

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

Investigating.

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

:glandium: What are options here? I don't know if I have sufficient knowledge to make ASAN builds work again, but I'm willing to give it a try, if that's what's necessary to get this to ship.

Comment 7

[Mike Hommey [:glandium]]

Can you try updating to rustc to ab1527f1d6560168f9fd36fa8cd7ba677c1d36ad? It's rustc before the changes that break the patches, and thankfully supports unsafe extern.

Comment 8

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #7)

Can you try updating to rustc to ab1527f1d6560168f9fd36fa8cd7ba677c1d36ad? It's rustc before the changes that break the patches, and thankfully supports unsafe extern.

Note that would be a short term solution, because it would soon lead to confusion as to why some constructs from 1.82 lead to build errors on asan builds because it's not a full 1.82.

Comment 9

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1945020 - docs(rust): note Rust version as 1.76 for Firefox 136 r=glandium

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/927d80214012
docs(rust): note Rust version as 1.76 for Firefox 136 r=glandium

Comment 11

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/927d80214012

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92f2e85a4d1d
build(rust): bump minimum Rust version 1.76 → 1.82 r=glandium

Comment 13

[Serban Stanca [:SerbanS]]

Backed out for causing sm bustages in math-fdlibm-sincostan.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/resist-fingerprinting/math-fdlibm-sincostan.js | /builds/worker/checkouts/gecko/js/src/jit-test/tests/resist-fingerprinting/math-fdlibm-sincostan.js:87:11 Error: Assertion failed: got false, expected true (code 3, args "") [0.1 s]

Comment 14

[Erich Gubler [:ErichDonGubler] (he/him)]

I...don't think the failure is related, so I'll try landing it again. We'll see if my hubris pans out. 🤪

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e66bc1e8bbab
build(rust): bump minimum Rust version 1.76 → 1.82 r=glandium

Comment 16

[Atila Butkovits]

Backed out for causing SM bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/30b300796bc51245ef43d2bc33930c9d767f5fd5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e66bc1e8bbab0e76e6843fff72bc98ab282efe60&selectedTaskRun=f-gHaTeSQ0GTuV_3xcjbmA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=493953908&repo=autoland&lineNumber=36527

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86f04c8644c2
build(rust): bump minimum Rust version 1.76 → 1.82 r=glandium

Comment 18

[amarc]

https://hg.mozilla.org/mozilla-central/rev/86f04c8644c2

Comment 19

[amarc]

Backed out changeset 86f04c8644c2 for causing build bustages

• Backout link
• Push with failures
• Failure Log
• Failure line:

error: linking with `/builds/worker/checkouts/gecko/build/cargo-linker` failed: exit status: 254

Comment 20

[Erich Gubler [:ErichDonGubler] (he/him)]

Sigh, will investigate.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed1adda514e3
build(rust): bump minimum Rust version 1.76 → 1.82 r=glandium

Comment 22

[agoloman]

Backed out for causing build bustages @cargo-linker.

• Backout link
• Push with failures
• Failure Log

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae5640375b7e
build(rust): bump minimum Rust version 1.76 → 1.82 r=glandium

Comment 24

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ae5640375b7e