1945080 - Contextual search actions should trigger a search immediately

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Moritz Beier [:mbeier]]

Attachment: contextual search button

When the user clicks a contextual search suggestion (first attachment), it immediately triggers a search. However, when they click a quick action to search with an already installed engine (second attachment), it activates search mode. This is somewhat confusing as both buttons look identical.

We should add the ability to shift-click quick actions to search with an installed engine to immediately trigger a search to make the behavior consistent with the old one-off buttons.
Maybe we should even consider to always trigger the search instead of activating search mode to make it consistent with contextual search.

Comment 1

[Moritz Beier [:mbeier]]

Attachment: quick action button

Comment 2

[Dale Harvey (:daleharvey)]

So the difference in behaviour is / should not be dependent on the type of result I dont think. If the user clicks an installed engine they enter search mode, if the user clicks an uninstalled engine they search (and are eventually prompted to install).

One difference in behaviour is if an engine is matched by its name ie "duck", then we should not persist the search term, if the engine is matched because of the context, the search term should persist. I just did a quick test and it looks like ^ might be broken, If I type "test" while on wikipedia.com then click the action I enter search mode with no search term.

Maybe we should even consider to always trigger the search instead of activating search mode to make it consistent with contextual search.

I think that is worth asking UX about, particuilarly since we can still enter and persist the search mode for the installed engine, having it immmediately perform a search seems like it may be what the users usually want to be doing

Comment 3

[Dale Harvey (:daleharvey)]

So to follow up on this with a discussion with UX

As mentioned if we match the engine name ie the user types "duck", we should not be doing a search on "duck", we should enter duckduckgo search mode and await the user to enter their query. It would be confusing for us to have the same button do 2 different things depending on the type of match so we want to maintain current behaviour now.

But adding an option tto allow shift+click perform a search seems sensible

Comment 4

[Moritz Beier [:mbeier]]

Just to make sure I'm not misunderstanding: The same button already does 2 different things (depending on whether the engine of the current page is installed or offered via opensearch but not installed) right?

I think both

1. typing "duck" while on any page and pressing the button to go into ddg search mode
2. typing "Firefox" while on Wikipedia and pressing the button to immediately search Wikipedia

are intuitive.

If we go into search mode in case 2, the user has to press enter after clicking the search with button, which was a bit unexpected for me because I already typed the whole query when I pressed the button. It would make sense to go into search mode if you could click the button before typing the query, but it only appears after typing something so the user most likely has finished his query when clicking it.

But yeah shift+click might be enough already.

Comment 5

[Mark Banner (:standard8)]

Please can you update the bug once the discussion with UX has been held?

Comment 6

[Dale Harvey (:daleharvey)]

Forgot to come back to this, so particularly now as we have update the behaviour for the unified search to perform searches immediately when a search term is present, actions should do the same

Comment 7

[Dale Harvey (:daleharvey)]

Forgot to come bac

Comment 8

[dong]

Attachment: Bug 1945080 - Update contextual search actions to trigger search immediately. r=daleharvey

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f471c7e2219b
https://hg.mozilla.org/integration/autoland/rev/052eca4cb35d
Update contextual search actions to trigger search immediately. r=daleharvey,urlbar-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0bef2a93f6af
https://hg.mozilla.org/integration/autoland/rev/f83d8bd6bb2f
Revert "Bug 1945080 - Update contextual search actions to trigger search immediately. r=daleharvey,urlbar-reviewers" for causing bc failures at contextualsearch_install

Comment 11

[Silaghi Andreea]

Backed out for causing bc failures at contextualsearch_install
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_contextualsearch_install.js | test_contextualsearch_install - Test timed out

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d640abeb62c7
https://hg.mozilla.org/integration/autoland/rev/55b668965de2
Update contextual search actions to trigger search immediately. r=daleharvey,urlbar-reviewers

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/55b668965de2