Closed Bug 1945104 Opened 23 days ago Closed 21 days ago

[wpt-sync] Sync PR 50408 - [functions] Handle fallbacks for local substitutions

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50408 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50408
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[functions] Handle fallbacks for local substitutions

Now that CL:6187537 made the fallback available before local/argument
resolution, we can simply substitute the fallback when
the local/argument is invalid.

Bug: 325504770
Change-Id: Ia0df24ffaddb2557b64939467a9449a0783e9275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187553
Reviewed-by: Steinar H Gunderson \<sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1414022}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 2
FAIL: 39

Chrome

OK : 2
FAIL: 39

Safari

OK : 2
FAIL: 39

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-mixins/dashed-function-eval.html [wpt.fyi]
    • Literal result: FAIL (Chrome: FAIL, Safari: FAIL)
    • Literal result, typed return: FAIL (Chrome: FAIL, Safari: FAIL)
    • Literal result, typed return, calc: FAIL (Chrome: FAIL, Safari: FAIL)
    • Literal result, typed return, mismatch: FAIL (Chrome: FAIL, Safari: FAIL)
    • Missing result descriptor: FAIL (Chrome: FAIL, Safari: FAIL)
    • Literal result, empty: FAIL (Chrome: FAIL, Safari: FAIL)
    • result cascading behavior: FAIL (Chrome: FAIL, Safari: FAIL)
    • Another dashed-function in result: FAIL (Chrome: FAIL, Safari: FAIL)
    • Unused argument: FAIL (Chrome: FAIL, Safari: FAIL)
    • Single parameter: FAIL (Chrome: FAIL, Safari: FAIL)
    • Multiple parameters: FAIL (Chrome: FAIL, Safari: FAIL)
    • Single parameter, typed: FAIL (Chrome: FAIL, Safari: FAIL)
    • Typed parameter with calc(): FAIL (Chrome: FAIL, Safari: FAIL)
    • Untyped parameter with calc(): FAIL (Chrome: FAIL, Safari: FAIL)
    • Various typed parameters: FAIL (Chrome: FAIL, Safari: FAIL)
    • Parameter with complex type (auto): FAIL (Chrome: FAIL, Safari: FAIL)
    • Parameter with complex type (px): FAIL (Chrome: FAIL, Safari: FAIL)
    • Passing argument to inner function: FAIL (Chrome: FAIL, Safari: FAIL)
    • var() in argument resolved before call: FAIL (Chrome: FAIL, Safari: FAIL)
    • var() in argument resolved before call, typed: FAIL (Chrome: FAIL, Safari: FAIL)
    • Single parameter with default value: FAIL (Chrome: FAIL, Safari: FAIL)
    • Multiple parameters with defaults: FAIL (Chrome: FAIL, Safari: FAIL)
    • Multiple parameters with defaults, typed: FAIL (Chrome: FAIL, Safari: FAIL)
    • Unused local: FAIL (Chrome: FAIL, Safari: FAIL)
    • Local does not affect outer scope: FAIL (Chrome: FAIL, Safari: FAIL)
    • Substituting local in result: FAIL (Chrome: FAIL, Safari: FAIL)
    • Substituting multiple locals in result: FAIL (Chrome: FAIL, Safari: FAIL)
    • Local referring to another local: FAIL (Chrome: FAIL, Safari: FAIL)
    • Locals appearing after result: FAIL (Chrome: FAIL, Safari: FAIL)
    • Locals cascading behavior: FAIL (Chrome: FAIL, Safari: FAIL)
    • Custom properties are visible inside function: FAIL (Chrome: FAIL, Safari: FAIL)
    • Parameter shadows custom property: FAIL (Chrome: FAIL, Safari: FAIL)
    • Local shadows parameter: FAIL (Chrome: FAIL, Safari: FAIL)
    • Missing only argument: FAIL (Chrome: FAIL, Safari: FAIL)
    • Missing one argument of several: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-mixins/local-var-substitution.html [wpt.fyi]
    • Fallback directly in result: FAIL (Chrome: FAIL, Safari: FAIL)
    • Fallback via present, but invalid local: FAIL (Chrome: FAIL, Safari: FAIL)
    • Fallback is locally resolved (result): FAIL (Chrome: FAIL, Safari: FAIL)
    • Fallback is locally resolved (local var): FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2123cb2f51dc [wpt PR 50408] - [functions] Handle fallbacks for local substitutions, a=testonly https://hg.mozilla.org/integration/autoland/rev/0c231d883c7d [wpt PR 50408] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2123cb2f51dc
https://hg.mozilla.org/mozilla-central/rev/0c231d883c7d

Status: NEW → RESOLVED
Closed: 21 days ago
: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.