1945113 - Add "isNonEmptyArray" assertion method to Assert.sys.mjs

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Alexandra Borovova [:Sasha]]

Follow-up from review: https://phabricator.services.mozilla.com/D235927#inline-1310622. Since the WebDriver BiDi spec has quite a few commands which expect the arguments to be non-empty arrays, we have a lot of places (e.g. script, session modules) where we required to check it, so it might be useful to reduce code duplication to add a new assertion method to Assert.sys.mjs.

Comment 1

[Spencer]

May I take on this bug if it's still available?

Comment 2

[Alexandra Borovova [:Sasha]]

(In reply to Spencer from comment #1)

May I take on this bug if it's still available?

Yes, go ahead!
Let me know if you have any questions :)

Comment 3

[Spencer]

Attachment: Bug 1945113 - [WebDriverBiDi] Add isNonEmptyArray assertion method to Assert.sys.mjs. r=Sasha

• Added isNonEmptyArray assert to Assert.sys.mjs.
• Refactored code that checked if an array was non-empty and replaced
  each occurrence with an isNonEmptyArray callback.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d91ce8f06ce5
[WebDriverBiDi] Add isNonEmptyArray assertion method to Assert.sys.mjs. r=Sasha,webdriver-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d91ce8f06ce5

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thank you Spencer for another nice addition to our code!