1945178 - Reset the search settings when corrupted

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P2)

Description

[Moritz Beier [:mbeier]]

When there is an exception while reading the search settings, we should reset them. Otherwise, the user will not be able to search at all which is worse than losing their opensearch engines and default engine.

We should also:

• Add telemetry on the frequency of such failures to help identify issues
• Back up the corrupted settings file to reproduce issues
• Display a banner informing the user

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 1945178 - Reset the search settings when corrupted. r?standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec5ec675b76b
Reset the search settings when corrupted. r=Standard8,fluent-reviewers,bolsson

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ec5ec675b76b

Comment 4

[Magnus Melin [:mkmelin]]

https://hg-edge.mozilla.org/mozilla-central/rev/ec5ec675b76b#l9.12 is causing test failures for Thunderbird as this is toolkit/ code referring to browser/ (which Thunderbird does not have)

Comment 5

[Moritz Beier [:mbeier]]

Sorry for that. I didn't notice and the linter rule that should catch this is disabled in tests for some reason. It will be fixed in Bug 1959924.

Comment 6

[Magnus Melin [:mkmelin]]

Thanks!!