1945184 - Implement "browsingContext.navigationCommitted" event

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This bug is used for the implementation of the browsingContext.navigationCommitted event.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Tests were added upstream and are going to be synced via bug 1945175.

Comment 2

[Julian Descottes [:jdescottes]]

Setting backlog, but this should definitely be in the next milestone

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There are also quite a number of pytest and pluggy errors visible since bug 1946426 got landed on mozilla-central. The error line looks like SystemError: AST constructor recursion depth mismatch (before=129, after=182). We should check if that gets fixed as well when we have support for this event.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1945184 - [bidi] Implement browsingContext.navigationCommitted event

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3a46aedc914
[bidi] Implement browsingContext.navigationCommitted event r=webdriver-reviewers,Sasha

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a78d767ae4c8
Revert "Bug 1945184 - [bidi] Implement browsingContext.navigationCommitted event r=webdriver-reviewers,Sasha" for causing wpt failures on prefetch-transfer-size-executor.html.

Comment 8

[Iulian Moraru]

Revert for causing multiple issues.

• Push that was backed out

• Failure log

• Backout link

[task 2025-05-23T18:10:11.126Z] 18:10:11     INFO - TEST-START | /navigation-timing/prefetch-transfer-size-executor.html
[task 2025-05-23T18:10:11.148Z] 18:10:11     INFO - Closing window f1cd6a3f-4077-4631-9496-ebd742ef43df
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - 
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-PASS | /navigation-timing/nav2-test-redirect-none.html | Naivation without redirects. 
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-PASS | /navigation-timing/nav2-test-redirect-server.html | Navigation Timing 2 WPT 
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-PASS | /navigation-timing/nav2-test-redirect-xserver.html | Navigation Timing 2 WPT 
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-FAIL | /navigation-timing/nav2-test-response-end-and-duration-before-during-and-after-load-event.html | Check that performance.getEntriesByType('navigation')[0].responseEnd has reasonable values before and after the load has finished - assert_equals: PerformanceNavigationTiming.responseEnd == 0 before load event expected 0 but got 19.62
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - @http://web-platform.test:8000/navigation-timing/nav2-test-response-end-and-duration-before-during-and-after-load-event.html:17:18
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2684:25
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - Test.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:2759:32
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-FAIL | /navigation-timing/nav2-test-timing-persistent.html | iframe navigation times are persistent after the iframe is removed. Part 1. - assert_greater_than: timing values should be positive numbers: loadEventEnd expected a number greater than 0 but got 0
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - verify_timing@http://web-platform.test:8000/navigation-timing/nav2-test-timing-persistent.html:46:28
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - @http://web-platform.test:8000/navigation-timing/nav2-test-timing-persistent.html:69:22
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - @http://web-platform.test:8000/navigation-timing/nav2-test-timing-persistent.html:63:13
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-PASS | /navigation-timing/nav2-test-timing-persistent.html | iframe navigation times are persistent after the iframe is removed Part 2. 
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-PASS | /navigation-timing/nav2-test-unique-nav-instances.html | Each window has a unique nav timing 2 instance. 
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-PASS | /navigation-timing/navigation-type-post-backforward.html | Navigation type after posting and navigating away and back should be back_forward. 
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-PASS | /navigation-timing/nested-unload-timing.html | Navigation Timing: unload event with nested contexts 
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-PASS | /navigation-timing/po-navigation.html | navigation entry is observable 
[task 2025-05-23T18:10:41.903Z] 18:10:41     INFO - TEST-UNEXPECTED-TIMEOUT | /navigation-timing/prefetch-transfer-size-executor.html | Navigation timing transfer size for a prefetched navigation should be 0. - Test timed out
[task 2025-05-23T18:10:41.978Z] 18:10:41     INFO - TEST-UNEXPECTED-TIMEOUT | /navigation-timing/prefetch-transfer-size-executor.html | expected OK
[task 2025-05-23T18:10:41.978Z] 18:10:41     INFO - TEST-INFO took 30852ms
[task 2025-05-23T18:10:42.664Z] 18:10:42     INFO - Closing logging queue
[task 2025-05-23T18:10:42.665Z] 18:10:42     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2025-05-23T18:10:42.665Z] 18:10:42     INFO - queue closed
[task 2025-05-23T18:10:42.678Z] 18:10:42     INFO - Setting up ssl
[task 2025-05-23T18:10:42.716Z] 18:10:42     INFO - certutil | b''
[task 2025-05-23T18:10:42.751Z] 18:10:42     INFO - certutil | b''
[task 2025-05-23T18:10:42.765Z] 18:10:42     INFO - certutil | b'\nCertificate Nickname                                         Trust Attributes\n                                                             SSL,S/MIME,JAR/XPI\n\nweb-platform-tests                                           CT,, \n'
[task 2025-05-23T18:10:43.448Z] 18:10:43     INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test_runner
[task 2025-05-23T18:10:44.563Z] 18:10:44     INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.TestRunnerActivity -a android.intent.action.MAIN --es env0 MOZ_CRASHREPORTER=1 --es env1 MOZ_CRASHREPORTER_NO_REPORT=1 --es env2 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env4 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env6 R_LOG_LEVEL=6 --es env7 R_LOG_DESTINATION=stderr --es env8 R_LOG_VERBOSE=1 --es env9 MOZ_PROCESS_LOG=/tmp/tmpl98cbmo3pidlog --es env10 MINIDUMP_SAVE_PATH=/builds/worker/workspace/build/blobber_upload_dir --es env11 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es arg0 -no-remote --es arg1 -profile --es arg2 /data/local/tmp/test_root/profile --es arg3 --marionette --es arg4 --remote-allow-system-access --es arg5 about:blank
[task 2025-05-23T18:10:46.034Z] 18:10:46     INFO - Starting runner
[task 2025-05-23T18:10:49.205Z] 18:10:49     INFO - TEST-START | /navigation-timing/prefetch-transfer-size-iframe.html
``

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be2605c4605c
[bidi] Implement browsingContext.navigationCommitted event r=webdriver-reviewers,Sasha

Comment 10

[Serban Stanca [:SerbanS]]

Relanded this as this was not the real culprit for the issue above.

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/be2605c4605c