1945202 - [wpt-sync] Sync PR 50415 - Provide layer bounds for text-shadow rendering

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50415 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50415
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Provide layer bounds for text-shadow rendering

Lower layers have trouble culling away the shadows (and/or overestimate
their bounds) which lead to high raster costs.

Pass the computed visual rect for the text fragment when setting up the
layer for the shadow. This appears to reduce the raster cost
significantly in the case described in the bug.

Add a physical version of InkOverflow::ExpandForShadowOverflow and
simplify the application of the text-shadow ink overflow contribution.
This also fixes an issue where the ink overflow was miscalculated for
the vertical-lr writing mode.

Guard with the flag "TextShadowPaintingOptimization".

Bug: 391914237
Change-Id: I847d0a8291150ec1a92d4e7424c3a09eeecca134
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6213771
Commit-Queue: Fredrik Söderquist \<[e-mail]>
Reviewed-by: Stephen Chenney \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1414139}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3139ff5b29e40ec62d0048c6feb6cfb0bbae6aa8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-pseudo/highlight-painting-001.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22f40f94cf2e
[wpt PR 50415] - Provide layer bounds for text-shadow rendering, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/22f40f94cf2e