1945237 - [wpt-sync] Sync PR 50418 - Language Detector: Implement signal for AILanguageDetectorFactory.create

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50418 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50418
Details from upstream follow.

Nathan Memmott <[e-mail]> wrote:

Language Detector: Implement signal for AILanguageDetectorFactory.create

Partially implement the signal option for
AILanguageDetectorFactory.create. Rejects when the create is called with
an already aborted signal.

Bug: 391712909
Change-Id: I0c5f935a558e6558ed7afecccdb9e9c8331e5c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6216485
Commit-Queue: Nathan Memmott \<[e-mail]>
Reviewed-by: Jiacheng Guo \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1414243}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 50418 applied with additional changes from upstream: 344a03be82e877514add8ca332c790ff2e707a40

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7dc4222dde4329caa50fb3844e6ca8da1f39c14

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 3 subtests

Status Summary

Firefox

OK : 4
FAIL : 12

Chrome

TIMEOUT: 8
NOTRUN : 8

Safari

OK : 4
FAIL : 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /ai/language_detection/detector.https.tentative.any.html [wpt.fyi]
  • Simple AILanguageDetector.detect() call: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • AILanguageDetectorFactory.create() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • AILanguageDetector.detect() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
• /ai/language_detection/detector.https.tentative.any.sharedworker.html [wpt.fyi]
  • Simple AILanguageDetector.detect() call: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • AILanguageDetectorFactory.create() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • AILanguageDetector.detect() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
• /ai/language_detection/detector.https.tentative.any.serviceworker.html [wpt.fyi]
  • Simple AILanguageDetector.detect() call: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • AILanguageDetectorFactory.create() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • AILanguageDetector.detect() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
• /ai/language_detection/detector.https.tentative.any.worker.html [wpt.fyi]
  • Simple AILanguageDetector.detect() call: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • AILanguageDetectorFactory.create() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • AILanguageDetector.detect() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09ac5803c981
[wpt PR 50418] - Language Detector: Implement signal for AILanguageDetectorFactory.create, a=testonly
https://hg.mozilla.org/integration/autoland/rev/14214f15bb76
[wpt PR 50418] - Update wpt metadata, a=testonly

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/09ac5803c981
https://hg.mozilla.org/mozilla-central/rev/14214f15bb76