1945286 - [wpt-sync] Sync PR 50422 - Remove special boolean handling in ResolveToConfigResolved::React()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50422 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50422
Details from upstream follow.

Nate Chapin <[e-mail]> wrote:

Remove special boolean handling in ResolveToConfigResolved::React()

Instead of following standard JS rules for coercing an aribtary value to
a boolean, it was treating non-booleans as false. A use counter shows
that this behavior isn't relied upon, so use the standard behavior.

Change-Id: I3b4424064f6728b8206166d3df86dd42b71af520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6219805
Commit-Queue: Nate Chapin \<[e-mail]>
Reviewed-by: Maks Orlovich \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1414449}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=13ba70a6c0d03346c6f35c36e113971b125c9983

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
FAIL: 4

Safari

OK : 1
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fenced-frame/resolve-to-config-promise.https.html [wpt.fyi]
  • resolveToConfig set to a promise that resolves to true: FAIL (Chrome: FAIL, Safari: FAIL)
  • resolveToConfig set to a promise that resolves to false: FAIL (Chrome: FAIL, Safari: FAIL)
  • resolveToConfig set to a promise that immediately resolves: FAIL (Chrome: FAIL, Safari: FAIL)
  • resolveToConfig set to a promise that resolves to an non-boolean value: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7af7e7e18539
[wpt PR 50422] - Remove special boolean handling in ResolveToConfigResolved::React(), a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7af7e7e18539