Closed Bug 1945325 Opened 9 months ago Closed 6 months ago

Use custom controller for userlist and tidy up some controller use in cZ

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Future
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.21)

Attachments

(1 file)

At the moment we special case cmd_selectAll to check if it is for the userlist or not. To make it easier to use existing suite code we can use a custom controller for the userlist. Whilst here switch the cZ code to use toolkit's goDoCommand rather than duplicating the code.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9463323 - Flags: review?(frgrahl)
Attachment #9463323 - Flags: approval-comm-release?
Whiteboard: SM2.53.21

Comment on attachment 9463323 [details] [diff] [review]
1945325-irc-userlist-controller-25321.patch

LGTM r/a+

Attachment #9463323 - Flags: review?(frgrahl)
Attachment #9463323 - Flags: review+
Attachment #9463323 - Flags: approval-comm-release?
Attachment #9463323 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/517c1cccdbe9
Use custom controller for userlist and tidy up some controller use in cZ. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/21512255a8511ed5fc8721206bc0b1aafebda5f2
Use custom controller for userlist and tidy up some controller use in cZ. r=frg a=frg

Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: