1945420 - [contextual-password-manager] "Close Without Saving?" warning loses focus when Tab is pressed

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P3)

Description

[Ina Popescu, Desktop QA]

Found in

• Nightly 136.0a1

Affected versions

• Nightly 136.0a1

Tested platforms

• Affected platforms: Windows 11, macOS 13 ARM, Ubuntu 22.04
• Unaffected platforms: none

Preconditions:

• Set pref browser.contextual-password-manager.enabled to true in about:config
• Enable Sidebar
• Have several saved password records

Steps to reproduce

1. Start editing an entry and attempt to close the sidebar without saving
2. Press the Tab key when the "Close without saving?" warning appears
3. Observe where the focus moves.

Expected result

• Pressing Tab should focus the "Confirm" and "Go Back" buttons when the "Close without saving?" warning appears.

Actual result

• Pressing Tab moves focus to the web content making it harder to navigate the warning dialog using the keyboard.

Regression range

• N/A

Additional notes

• Please see the screen recording.

Comment 1

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I am also able to reproduce this for the duplicate notification as well, using Firefox 138.0b5.

Comment 2

[Ryan Safaeian [:rsafaeian]]

Attachment: Bug 1945420 - [contextual-password-manager] Focus "Close Without Saving?" notification after tabbing on the last button in login-form.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c354352ebc3
[contextual-password-manager] Focus "Close Without Saving?" notification after tabbing on the last button in login-form. r=mtigley,credential-management-reviewers

Comment 4

[Atila Butkovits]

Backed out for causing geckoview failures.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/8f95b50b5d5ea28aeb3434e2e3ad6573a45df9a6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7c354352ebc356a767b208552657087eb8816329&selectedTaskRun=bf6t4jZPSdC_41sELUaeVg.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=504528154&repo=autoland&lineNumber=13166
https://treeherder.mozilla.org/logviewer?job_id=504533095&repo=autoland&lineNumber=13050

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:rsafaeian, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5dbb043f7f78
https://hg.mozilla.org/integration/autoland/rev/23a28f09bacd
[contextual-password-manager] Focus "Close Without Saving?" notification after tabbing on the last button in login-form. r=mtigley,credential-management-reviewers

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/23a28f09bacd

Comment 8

[Ina Popescu, Desktop QA]

There's a difference in how Tab and Shift+Tab work on and Windows when the "Close without saving?" and duplicate password notifications are shown in the Passwords panel.

• On macOS and Ubuntu, pressing Tab can move focus to the X button (to close the panel) first, then through the notification buttons and the edit form. After reaching the edit form, the X button can only be reached again with Shift+Tab.
• On Windows, pressing Tab moves focus through the notification buttons and edit form, but not the X button. It’s only reachable with Shift+Tab. When the duplicate warning is shown, focus first goes to the Cancel button, then to the "Go to password" button inside the notification.

Should the "X" button to close the Passwords panel be reachable using Tab while notifications are present, as it is on macOS and Ubuntu?
Please see the following recording taken on macOS 15 showing this behavior( first using Tab, then using Shift+Tab to reach the X button again). Let me know if any other details are needed. Thank you.