1945427 - Loosen netwerk/test/browser/browser_103_assets.js expectation for possibly-cached preload

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Description

[Tooru Fujisawa [:arai]]

browser_103_assets.js testcase observes the "earlyhints-connectback" notification:

https://searchfox.org/mozilla-central/rev/b1662b447f306e6554647914090d4b73ac8e1664/netwerk/test/browser/browser_103_assets.js#50

Services.obs.addObserver(observer, "earlyhints-connectback");

The notification is generated by EarlyHintPreloader::OnParentReady, which is called only when the AsyncOpen is called for the channel.

https://searchfox.org/mozilla-central/rev/b1662b447f306e6554647914090d4b73ac8e1664/netwerk/protocol/http/EarlyHintPreloader.cpp#532,539

void EarlyHintPreloader::OnParentReady(nsIParentChannel* aParent) {
...
    obs->NotifyObservers(mChannel, "earlyhints-connectback", nullptr);

Once the in-memory script cache (mozilla::dom::SharedScriptCache) is integrated into script preload,
the preload can skip the channel open if the script is found in the in-memory cache.

Given the notification is testing-only, I'd like to modify the testcase to allow the case where the notification isn't observed for cached script case.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1945427 - Allow a cached script not to be notified. r?#necko-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b154fece72b2
Allow a cached script not to be notified. r=necko-reviewers,valentin DONTBUILD

Comment 3

[Tooru Fujisawa [:arai]]

sorry, I accidentally clicked the DONTBUILD checkbox

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b154fece72b2