Closed Bug 1945440 Opened 11 months ago Closed 11 months ago

Dragging tabs is broken in right-to-left mode

Categories

(Firefox :: Tabbed Browser, defect, P1)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox134 --- unaffected
firefox135 --- unaffected
firefox136 --- verified
firefox137 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-tabgrps-dnd])

Attachments

(1 file)

Bug 1945440 - Fix tab drag and drop in RTL mode. r=dwalker,jswinarton
48 bytes, text/x-phabricator-request
dmeehan
: approval-mozilla-beta+
Details | Review

This is a regression from bug 1932489.

Severity: -- → S2
Points: 1 → 2
status-firefox134: --- → unaffected
status-firefox135: --- → unaffected
status-firefox136: --- → affected
status-firefox-esr115: --- → unaffected
status-firefox-esr128: --- → unaffected
Priority: -- → P1
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Points: 2 → 1
Flags: qe-verify+
Pushed by jswinarton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9858f7c10e8d Fix tab drag and drop in RTL mode. r=jswinarton,tabbrowser-reviewers

https://hg.mozilla.org/mozilla-central/rev/9858f7c10e8d

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox137: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

I have reproduced this issue using Firefox 136.0a1 (2025.02.01) RTL build on Windows 10.
I can confirm this issue is fixed, I verified using Firefox 137.0a1 (2024.02.04) RTL build on Windows 10, Ubuntu 22 and on macOS 12, now dragging tabs are working as expected.

status-firefox137: fixed → verified
Flags: qe-verify+
See Also: → 1945788

Comment on attachment 9463422 [details]
Bug 1945440 - Fix tab drag and drop in RTL mode. r=dwalker,jswinarton

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Dragging tabs is busted in RTL locales
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Pretty simple one-line fix, verified by QA. However, please note that I'm also looking into bug 1945788 which will likely need another uplift.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9463422 - Flags: approval-mozilla-beta?
Blocks: 1945644

Comment on attachment 9463422 [details]
Bug 1945440 - Fix tab drag and drop in RTL mode. r=dwalker,jswinarton

Approved for 136.0b2

Attachment #9463422 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I can confirm this issue is fixed, I verified using Firefox 136.0b2 with RTL build on Windows 10, Ubuntu 22 and on macOS 10.15, now dragging tabs are working as expected.

Status: RESOLVED → VERIFIED
status-firefox136: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: