Closed
Bug 1945459
Opened 6 months ago
Closed 6 months ago
Add TypeScript definitions for Glean interfaces
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox137 fixed)
RESOLVED
FIXED
137 Branch
Tracking | Status | |
---|---|---|
firefox137 | --- | fixed |
People
(Reporter: standard8, Assigned: zombie)
References
(Blocks 1 open bug)
Details
(Whiteboard: [addons-jira])
Attachments
(1 file)
The Glean
interface is part of the output of the metrics.yaml
and other files. Currently TypeScript does not know about these being available on the GleanImpl
type, and so errors:
toolkit/components/search/AddonSearchEngine.sys.mjs:126:13 - error TS2339: Property 'browserSearchinit' does not exist on type 'GleanImpl'.
126 Glean.browserSearchinit.engineInvalidWebextension[this._extensionID].set(
~~~~~~~~~~~~~~~~~
Assignee | ||
Comment 1•6 months ago
|
||
Only partially automated for now, requires a manual step for each metrics.yaml,
to test things out, and have folks actually review the output before landing.
Updated•6 months ago
|
Assignee: nobody → tomica
Status: NEW → ASSIGNED
Assignee | ||
Updated•6 months ago
|
Whiteboard: [addons-jira]
Updated•6 months ago
|
Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64f548234166
Add mach ts command for building Glean interfaces r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox137:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•