1945463 - [tab groups d&d] Fix greatestOverlap to account for elements completely overlapping one another

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P1)

Description

[Dão Gottwald [:dao]]

(In reply to tabmix.onemen from bug 1932489 comment #12)

The comment above greatestOverlap indicate
If the elements have different sizes, then this returns the larger overlap percentage.

but there is a 3rd case that you did not cover

*   p2            p1      p1+s1    p2+s2
*    |             |        |        |
*    ---------------------------------
*    =================================
*                   s2
*                  ==========
*                      s1
*                  ==========
*                   overlap

When element 1 is completely inside element 2 set overlapSize = s1
and the function greatestOverlap should return s1 in this case

Happy to look into this. Just so we're clear, is this a theoretical concern or does it cause problems in practice? If it's the latter, do you have steps to reproduce that problem?

Either way, I assume we'll need this for bug 1908439.

Comment 1

[tabmix.onemen]

I am using css to make each tab shrink to the content of its label.

.tabbrowser-tab:not([pinned]) {
  flex: 0 0 auto !important;
  width: auto !important;
}

it is possible to have tab with minimum width next to a tab with maximum width.

I hope you can modify gBrowser.tabContainer._animateTabMove to handle this use case.

notice that beside the issue explained in bug 1932489 comment #12, the value of tabSize should be (for non vertical mode) the width of the first or last dragging tab according to directionForward and #rtlMode

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1945463 - [tab groups d&d] Fix greatestOverlap to account for elements completely overlapping one another. r?jswinarton,dwalker

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf04cd0bf517
[tab groups d&d] Fix greatestOverlap to account for elements completely overlapping one another. r=jswinarton,tabbrowser-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bf04cd0bf517

Comment 5

[Dão Gottwald [:dao]]

(In reply to tabmix.onemen from comment #1)

notice that beside the issue explained in bug 1932489 comment #12, the value of tabSize should be (for non vertical mode) the width of the first or last dragging tab according to directionForward and #rtlMode

The patch in bug 1945788 takes care of this.