1945566 - Introduce moz-src protocol that maps packaged resources to source tree locations

Status: RESOLVED FIXED

(Firefox :: General, task, P1)

Description

[:Gijs (he/him)]

This is still a WIP and we're still working on discussing details with folks, getting approvals, etc., but I'm filing a bug so I can put up some WIP patches on phabricator and have somewhere to link folks who are interested in following along. The full proposal is still somewhat in flux but mostly settling down nicely at this point.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::UI Widgets' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1945566 - Add a moz-src protocol handler, r?#necko-reviewers!,#firefox-desktop-core-reviewers!

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1945566 - Add eslint and vscode module resolvers for moz-src, r?#firefox-desktop-core-reviewers

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1945566 - Add MOZ_SRC_FILES directive to moz.build, r?#firefox-build-system-reviewers

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1945566 - Add a mach command to allow people to update files they work with to moz-src, r?ahal

Comment 6

[:Gijs (he/him)]

This proposal was accepted by everyone involved so I've put up patches for review.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c19c6833ebdc
Add a moz-src protocol handler, r=necko-reviewers,firefox-desktop-core-reviewers ,extension-reviewers,robwu,mconley,valentin
https://hg.mozilla.org/integration/autoland/rev/9eba66d33006
Add eslint and vscode module resolvers for moz-src, r=firefox-desktop-core-reviewers ,frontend-codestyle-reviewers,mconley,Standard8
https://hg.mozilla.org/integration/autoland/rev/1b2bd35ca71f
Add MOZ_SRC_FILES directive to moz.build, r=firefox-build-system-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/6d69925d57ac
Add a mach command to allow people to update files they work with to moz-src, r=ahal

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages/py3 unit test failures/ bugzilla lint failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/b2e9e19b3af68d095cfc317d14bf41e408f2c2d9

Push with failures

Failure log -> error: $SRCDIR/browser/installer/package-manifest.in:206: Missing file(s): bin/moz-src/*

Failure log -> python/mozbuild/mozbuild/test/test_jarmaker.py::TestJarMaker::test_a_wildcard_jar TEST-UNEXPECTED-FAIL

Failure log ->FileToBugzillaMappingError: Missing Bugzilla component: srcdir-resolver.js - Set the BUG_COMPONENT in the moz.build file to fix the issue.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0ac0affac85
Add a moz-src protocol handler, r=necko-reviewers,firefox-desktop-core-reviewers ,extension-reviewers,robwu,mconley,valentin,tschuster
https://hg.mozilla.org/integration/autoland/rev/02892fe46067
Add eslint and vscode module resolvers for moz-src, r=firefox-desktop-core-reviewers ,frontend-codestyle-reviewers,mconley,Standard8
https://hg.mozilla.org/integration/autoland/rev/c2796bc13a10
Add MOZ_SRC_FILES directive to moz.build, r=firefox-build-system-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/0102aebf7a58
Add a mach command to allow people to update files they work with to moz-src, r=ahal

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f0ac0affac85
https://hg.mozilla.org/mozilla-central/rev/02892fe46067
https://hg.mozilla.org/mozilla-central/rev/c2796bc13a10
https://hg.mozilla.org/mozilla-central/rev/0102aebf7a58