Open Bug 1945683 Opened 13 days ago Updated 1 day ago

Enable layer compositor on Windows

Categories

(Core :: Graphics: WebRender, task)

task

Tracking

()

ASSIGNED

People

(Reporter: gw, Assigned: gw)

References

(Regressed 3 open bugs)

Details

(Keywords: perf-alert)

Attachments

(1 file)

No description provided.
Assignee: nobody → gwatson
Status: NEW → ASSIGNED

Sheriffs - this patch enables a very significant change to how we composite all pages on Windows. It passes all tests in CI, and seems OK in general browsing. However, given the scale of the change, I am expecting some regressions to occur when enabled in nightly. If / when this occurs, please just back this patch out (it's deliberately a very small patch to just enable a preference so it's easy to back out) as any regressions are likely to (a) affect a lot of users and (b) take me a while to investigate and resolve.

Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d8b4c0b99ed Enable layer compositor on Windows r=gfx-reviewers,lsalzman

Backed out for causing btime failures.

Flags: needinfo?(gwatson)

Patch to fix this is in 1946269 - will reland this once that passes try and lands.

Flags: needinfo?(gwatson)
See Also: → 1946487
Regressions: 1946487
Regressions: 1946657
Regressions: 1946766

(In reply to Serban Stanca [:SerbanS] from comment #4)

Backed out for causing btime failures.

Perfherder has detected a talos performance change from push e96db7f2fc84bf31d8081316be884a96496fecb6.

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
86% displaylist_mutate windows11-64-shippable-qr e10s fission stylo webrender 9,969.93 -> 1,349.22
14% rasterflood_gradient windows11-64-shippable-qr e10s fission stylo webrender 1,201.08 -> 1,370.33
11% rasterflood_svg windows11-64-shippable-qr e10s fission stylo webrender 10,012.49 -> 8,871.36

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43708

For more information on performance sheriffing please see our FAQ.

Keywords: perf-alert

(In reply to Serban Stanca [:SerbanS] from comment #4)

Backed out for causing btime failures.

Perfherder has detected a browsertime performance change from push e96db7f2fc84bf31d8081316be884a96496fecb6.

Regressions:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
11% speedometer Vanilla-ES2015-TodoMVC/DeletingItems/Async windows11-64-shippable-qr fission webrender 0.20 -> 0.22 Before/After
5% speedometer Vanilla-ES2015-TodoMVC/DeletingItems/Sync windows11-64-shippable-qr fission webrender 3.90 -> 4.09 Before/After

Improvements:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
79% motionmark-htmlsuite-1-3 powerUsage_gpu windows11-64-shippable-qr fission webrender 125.83 -> 26.20
26% motionmark-htmlsuite-1-3 cpuTime windows11-64-shippable-qr fission webrender 963.94 -> 714.08
17% speedometer Preact-TodoMVC/CompletingAllItems/Async windows11-64-shippable-qr fission webrender 2.98 -> 2.47 Before/After
14% speedometer VanillaJS-TodoMVC/Adding100Items/Async windows11-64-shippable-qr fission webrender 2.32 -> 2.00 Before/After
11% speedometer Preact-TodoMVC/CompletingAllItems windows11-64-shippable-qr fission webrender 3.88 -> 3.47 Before/After
... ... ... ... ... ...
2% speedometer AngularJS-TodoMVC windows11-64-shippable-qr fission webrender 106.11 -> 103.85 Before/After

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43703

For more information on performance sheriffing please see our FAQ.

Regressions: 1947292

(In reply to Pulsebot from comment #3)

Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d8b4c0b99ed
Enable layer compositor on Windows r=gfx-reviewers,lsalzman

Perfherder has detected a browsertime performance change from push 9d8b4c0b99ed4e5f39825c3c8890979ca64efdd8.

Improvements:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
8% speedometer Preact-TodoMVC/CompletingAllItems/Sync windows11-64-shippable-qr fission webrender 0.95 -> 0.88 Before/After
4% speedometer VanillaJS-TodoMVC/DeletingAllItems windows11-64-shippable-qr fission webrender 3.58 -> 3.43 Before/After
4% speedometer VanillaJS-TodoMVC/DeletingAllItems/Sync windows11-64-shippable-qr fission webrender 3.35 -> 3.21 Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43668

For more information on performance sheriffing please see our FAQ.

Regressions: 1947708
Regressions: 1948182
Regressions: 1948462
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: