1945683 - Enable layer compositor on Windows

Status: ASSIGNED

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1945683 - Enable layer compositor on Windows

Comment 2

[Glenn Watson [:gw]]

Sheriffs - this patch enables a very significant change to how we composite all pages on Windows. It passes all tests in CI, and seems OK in general browsing. However, given the scale of the change, I am expecting some regressions to occur when enabled in nightly. If / when this occurs, please just back this patch out (it's deliberately a very small patch to just enable a preference so it's easy to back out) as any regressions are likely to (a) affect a lot of users and (b) take me a while to investigate and resolve.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d8b4c0b99ed
Enable layer compositor on Windows r=gfx-reviewers,lsalzman

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing btime failures.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Glenn Watson [:gw]]

Patch to fix this is in 1946269 - will reland this once that passes try and lands.

Comment 6

[Mayank Bansal]

This also lead to large regressions on many tests :
https://treeherder.mozilla.org/perfherder/alerts?id=43667&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43656&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43686&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43678&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43673&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43671&hideDwnToInv=0

Note that these alerts are still being investigated by sheriffs, but backfills very strongly suggest that these alerts were caused by this bug. Once this bug was backed out, the metric numbers returned to pre-regression.