1945683 - Enable layer compositor on Windows in Nightly

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1945683 - Enable layer compositor on Windows

Comment 2

[Glenn Watson [:gw]]

Sheriffs - this patch enables a very significant change to how we composite all pages on Windows. It passes all tests in CI, and seems OK in general browsing. However, given the scale of the change, I am expecting some regressions to occur when enabled in nightly. If / when this occurs, please just back this patch out (it's deliberately a very small patch to just enable a preference so it's easy to back out) as any regressions are likely to (a) affect a lot of users and (b) take me a while to investigate and resolve.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d8b4c0b99ed
Enable layer compositor on Windows r=gfx-reviewers,lsalzman

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing btime failures.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Glenn Watson [:gw]]

Patch to fix this is in 1946269 - will reland this once that passes try and lands.

Comment 6

[Mayank Bansal]

This also lead to large regressions on many tests :
https://treeherder.mozilla.org/perfherder/alerts?id=43667&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43656&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43686&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43678&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43673&hideDwnToInv=0
https://treeherder.mozilla.org/perfherder/alerts?id=43671&hideDwnToInv=0

Note that these alerts are still being investigated by sheriffs, but backfills very strongly suggest that these alerts were caused by this bug. Once this bug was backed out, the metric numbers returned to pre-regression.

Comment 7

[Florin Bilt]

(In reply to Serban Stanca [:SerbanS] from comment #4)

Backed out for causing btime failures.

• Backout link
• Push with failures
• Failure Log

Perfherder has detected a talos performance change from push e96db7f2fc84bf31d8081316be884a96496fecb6.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
86%	displaylist_mutate	windows11-64-shippable-qr	e10s fission stylo webrender	9,969.93 -> 1,349.22
14%	rasterflood_gradient	windows11-64-shippable-qr	e10s fission stylo webrender	1,201.08 -> 1,370.33
11%	rasterflood_svg	windows11-64-shippable-qr	e10s fission stylo webrender	10,012.49 -> 8,871.36

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43708

For more information on performance sheriffing please see our FAQ.

Comment 8

[Acasandrei Beatrice (needinfo me)]

(In reply to Serban Stanca [:SerbanS] from comment #4)

Backed out for causing btime failures.

• Backout link
• Push with failures
• Failure Log

Perfherder has detected a browsertime performance change from push e96db7f2fc84bf31d8081316be884a96496fecb6.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
11%	speedometer Vanilla-ES2015-TodoMVC/DeletingItems/Async	windows11-64-shippable-qr	fission webrender	0.20 -> 0.22	Before/After
5%	speedometer Vanilla-ES2015-TodoMVC/DeletingItems/Sync	windows11-64-shippable-qr	fission webrender	3.90 -> 4.09	Before/After

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
79%	motionmark-htmlsuite-1-3 powerUsage_gpu	windows11-64-shippable-qr	fission webrender	125.83 -> 26.20
26%	motionmark-htmlsuite-1-3 cpuTime	windows11-64-shippable-qr	fission webrender	963.94 -> 714.08
17%	speedometer Preact-TodoMVC/CompletingAllItems/Async	windows11-64-shippable-qr	fission webrender	2.98 -> 2.47	Before/After
14%	speedometer VanillaJS-TodoMVC/Adding100Items/Async	windows11-64-shippable-qr	fission webrender	2.32 -> 2.00	Before/After
11%	speedometer Preact-TodoMVC/CompletingAllItems	windows11-64-shippable-qr	fission webrender	3.88 -> 3.47	Before/After
...	...	...	...	...	...
2%	speedometer AngularJS-TodoMVC	windows11-64-shippable-qr	fission webrender	106.11 -> 103.85	Before/After

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43703

For more information on performance sheriffing please see our FAQ.

Comment 9

[Alex Finder]

(In reply to Pulsebot from comment #3)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d8b4c0b99ed
Enable layer compositor on Windows r=gfx-reviewers,lsalzman

Perfherder has detected a browsertime performance change from push 9d8b4c0b99ed4e5f39825c3c8890979ca64efdd8.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
8%	speedometer Preact-TodoMVC/CompletingAllItems/Sync	windows11-64-shippable-qr	fission webrender	0.95 -> 0.88	Before/After
4%	speedometer VanillaJS-TodoMVC/DeletingAllItems	windows11-64-shippable-qr	fission webrender	3.58 -> 3.43	Before/After
4%	speedometer VanillaJS-TodoMVC/DeletingAllItems/Sync	windows11-64-shippable-qr	fission webrender	3.35 -> 3.21	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43668

For more information on performance sheriffing please see our FAQ.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1945683 - Enable layer compositor on Windows in Nightly

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c7b785cbc18d
https://hg.mozilla.org/integration/autoland/rev/476bf3a723b1
Enable layer compositor on Windows in Nightly r=gfx-reviewers,lsalzman

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/476bf3a723b1

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/782799050648
https://hg.mozilla.org/integration/autoland/rev/03f3e71928f5
Revert "Bug 1945683 - Enable layer compositor on Windows in Nightly r=gfx-reviewers,lsalzman" for causing performance regression on Speedometer 3 on Windows 11.

Comment 14

[agoloman]

Backout merged into central: https://hg-edge.mozilla.org/mozilla-central/rev/03f3e71928f5db04a68e19d0af6f92d3519d50c3

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5daef99508f3
https://hg.mozilla.org/integration/autoland/rev/3bf656ec4a64
Enable layer compositor on Windows in Nightly r=gfx-reviewers,lsalzman

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3bf656ec4a64

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/baa374a65199
https://hg.mozilla.org/integration/autoland/rev/017a5fb444d4
Revert "Bug 1945683 - Enable layer compositor on Windows in Nightly r=gfx-reviewers,lsalzman" for causing reftest failures

Comment 18

[Cristina Horotan [:chorotan]]

Reopening, should be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1971681#c8

Comment 19

[Cristina Horotan [:chorotan]]

Backout merged to central https://hg.mozilla.org/mozilla-central/rev/017a5fb444d4f5e1eb1772cd89db2244afa8cce4

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/585b6fd1d4d2
https://hg.mozilla.org/integration/autoland/rev/5adde51a4a33
Enable layer compositor on Windows in Nightly r=gfx-reviewers,lsalzman

Comment 21

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5adde51a4a33

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/397feb42dc22
https://hg.mozilla.org/integration/autoland/rev/1cfeac9e52c0
Revert "Bug 1945683 - Enable layer compositor on Windows in Nightly r=gfx-reviewers,lsalzman" for causing performance regression in a critical test (speedometer3).

Comment 23

[Atila Butkovits]

Backed out for causing performance regression in a critical test (speedometer3). (requested by sparky)

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/1cfeac9e52c09a98fb1a38c4b381c49aeded2ac3

Comment 24

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/1cfeac9e52c0

Comment 25

[Florin Bilt]

(In reply to Pulsebot from comment #13)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/782799050648
https://hg.mozilla.org/integration/autoland/rev/03f3e71928f5
Revert "Bug 1945683 - Enable layer compositor on Windows in Nightly
r=gfx-reviewers,lsalzman" for causing performance regression on Speedometer
3 on Windows 11.

(In reply to agoloman from comment #14)

Backout merged into central: https://hg-edge.mozilla.org/mozilla-central/rev/03f3e71928f5db04a68e19d0af6f92d3519d50c3

Perfherder has detected a browsertime performance change from push 03f3e71928f5db04a68e19d0af6f92d3519d50c3.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
10%	speedometer3 TodoMVC-Vue/CompletingAllItems/Sync	windows11-64-24h2-shippable	fission webrender	1.72 -> 1.55	Before/After
7%	speedometer3 TodoMVC-Preact-Complex-DOM/DeletingAllItems/Sync	windows11-64-24h2-shippable	fission webrender	1.11 -> 1.03	Before/After
7%	speedometer3 TodoMVC-Svelte-Complex-DOM/DeletingAllItems/Sync	windows11-64-24h2-shippable	fission webrender	1.27 -> 1.19	Before/After
6%	speedometer3 Charts-observable-plot/Dotted/Async	windows11-64-24h2-shippable	fission webrender	4.89 -> 4.59	Before/After
6%	speedometer3 TodoMVC-Lit-Complex-DOM/DeletingAllItems/Sync	windows11-64-24h2-shippable	fission webrender	1.89 -> 1.78	Before/After
...	...	...	...	...	...
2%	speedometer3	windows11-64-24h2-shippable	fission webrender	21.45 -> 21.89	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45548

The following documentation link provides more information about this command.

Comment 26

[Florin Bilt]

(In reply to Cristian Tuns from comment #24)

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/1cfeac9e52c0

Perfherder has detected a talos performance change from push 1cfeac9e52c09a98fb1a38c4b381c49aeded2ac3.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
35%	tp5o_scroll_paint_skip	windows11-64-24h2-shippable	e10s fission stylo webrender	0.70 -> 0.45
27%	tp5o_scroll	windows11-64-24h2-shippable	e10s fission stylo webrender	1.43 -> 1.05
18%	tscrollx	windows11-64-24h2-shippable	e10s fission stylo webrender	0.67 -> 0.55
10%	tart	windows11-64-24h2-shippable	e10s fission stylo webrender	1.96 -> 1.77
5%	displaylist_mutate	windows11-64-24h2-shippable	e10s fission stylo webrender	1,387.47 -> 1,312.22

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45653

The following documentation link provides more information about this command.

Comment 27

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #13)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/782799050648
https://hg.mozilla.org/integration/autoland/rev/03f3e71928f5
Revert "Bug 1945683 - Enable layer compositor on Windows in Nightly
r=gfx-reviewers,lsalzman" for causing performance regression on Speedometer
3 on Windows 11.

Perfherder has detected a browsertime performance change from push 03f3e71928f5db04a68e19d0af6f92d3519d50c3. As author of one of the patches included in that push, we need your help to address this regression.

Please acknowledge, and begin investigating this alert within 3 business days, or the patch(es) may be backed out in accordance with our regression policy. Our guide to handling regression bugs has information about how you can proceed with this investigation.

If you have any questions or need any help with the investigation, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1408%	facebook-nav.groups FirstVisualChange	windows11-64-24h2-shippable	cold fission webrender	56.39 -> 850.48
1153%	facebook-nav.groups PerceptualSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	68.04 -> 852.42
665%	imgur FirstVisualChange	windows11-64-24h2-shippable	fission warm webrender	109.78 -> 839.35
530%	facebook-nav.groups SpeedIndex	windows11-64-24h2-shippable	cold fission webrender	136.71 -> 861.23
258%	imgur PerceptualSpeedIndex	windows11-64-24h2-shippable	fission warm webrender	272.54 -> 975.18
254%	imgur ContentfulSpeedIndex	windows11-64-24h2-shippable	fission warm webrender	277.47 -> 980.98
208%	microsoft SpeedIndex	windows11-64-24h2-shippable	fission warm webrender	449.64 -> 1,384.55
117%	microsoft PerceptualSpeedIndex	windows11-64-24h2-shippable	fission warm webrender	1,170.76 -> 2,538.38
96%	instagram ContentfulSpeedIndex	windows11-64-24h2-shippable	bytecode-cached cold fission webrender	318.43 -> 624.86
96%	instagram ContentfulSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	314.75 -> 616.91
40%	outlook ContentfulSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	423.68 -> 594.20
18%	facebook ContentfulSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	396.80 -> 466.79
10%	microsoft SpeedIndex	windows11-64-24h2-shippable	cold fission webrender	592.10 -> 650.97
9%	microsoft PerceptualSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	1,314.52 -> 1,428.00
5%	microsoft LastVisualChange	windows11-64-24h2-shippable	cold fission webrender	6,040.06 -> 6,335.42

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
84%	reddit-billgates-post-1.comments LastVisualChange	windows11-64-24h2-shippable	cold fission webrender	370.05 -> 58.99
84%	reddit-billgates-post-1.billg SpeedIndex	windows11-64-24h2-shippable	cold fission webrender	389.56 -> 62.79
84%	reddit-billgates-post-1.comments PerceptualSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	132.74 -> 21.56
84%	reddit-billgates-post-1.billg FirstVisualChange	windows11-64-24h2-shippable	cold fission webrender	181.58 -> 29.50
84%	reddit-billgates-post-1.billg PerceptualSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	381.97 -> 62.26
...	...	...	...	...
2%	speedometer3 TodoMVC-jQuery/CompletingAllItems/total	windows11-64-24h2-shippable	fission webrender	69.17 -> 67.78

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45548

The following documentation link provides more information about this command.

Comment 28

[Andra Esanu (needinfo me)]

(In reply to Cristian Tuns from comment #24)

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/1cfeac9e52c0

Perfherder has detected a browsertime performance change from push 1cfeac9e52c09a98fb1a38c4b381c49aeded2ac3. As author of one of the patches included in that push, we need your help to address this regression.

Please acknowledge, and begin investigating this alert within 3 business days, or the patch(es) may be backed out in accordance with our regression policy. Our guide to handling regression bugs has information about how you can proceed with this investigation.

If you have any questions or need any help with the investigation, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
5%	welcome loadtime	windows11-64-24h2-shippable	cold fission webrender	34.38 -> 36.07

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
29%	pinterest powerUsage_gpu	windows11-64-24h2-shippable	cold fission webrender	209.52 -> 148.37	Before/After
25%	buzzfeed powerUsage_gpu	windows11-64-24h2-shippable	cold fission webrender	221.59 -> 167.22
24%	buzzfeed powerUsage_gpu	windows11-64-24h2-shippable	fission warm webrender	186.29 -> 140.78
19%	speedometer Preact-TodoMVC/DeletingItems/Sync	windows11-64-24h2-shippable	fission webrender	1.01 -> 0.82
13%	speedometer Preact-TodoMVC/DeletingItems	windows11-64-24h2-shippable	fission webrender	2.09 -> 1.83
...	...	...	...	...	...
2%	speedometer3 Perf-Dashboard/SelectingPoints/Sync	windows11-64-24h2-shippable	fission webrender	29.35 -> 28.76	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45652

The following documentation link provides more information about this command.

Comment 29

[Florin Bilt]

(In reply to Cristina Horotan [:chorotan] from comment #19)

Backout merged to central https://hg.mozilla.org/mozilla-central/rev/017a5fb444d4f5e1eb1772cd89db2244afa8cce4

Perfherder has detected a browsertime performance change from push 017a5fb444d4f5e1eb1772cd89db2244afa8cce4.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
13%	yahoo-mail SpeedIndex	windows11-64-24h2-shippable	cold fission webrender	159.87 -> 138.81	Before/After
8%	yahoo-mail FirstVisualChange	windows11-64-24h2-shippable	cold fission webrender	138.67 -> 127.41	Before/After
7%	yahoo-mail ContentfulSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	184.28 -> 171.16	Before/After
6%	yahoo-mail SpeedIndex	windows11-64-24h2-shippable	cold fission webrender	165.02 -> 154.38	Before/After
5%	yahoo-mail PerceptualSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	214.96 -> 204.54	Before/After
...	...	...	...	...	...
2%	yahoo-mail largestContentfulPaint	windows11-64-24h2-shippable	cold fission webrender	487.53 -> 477.60	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45752

The following documentation link provides more information about this command.

Comment 30

[Sotaro Ikeda [:sotaro]]

Current tests results.

• https://perf.compare/compare-results?baseRev=ce8919650180bedb05560485489a5ed8dfc1e9f7&baseRepo=try&newRev=f007b1915801e941a21a47dce7b78bd4e607e29b&newRepo=try&framework=13&filter\_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=48d7953d4ec3a73ac1c73efea3e1f9e57a0563a5&baseRepo=try&newRev=9a2007bb8b436df7d2a210daf27766a0c60f4d45&newRepo=try&framework=13&filter\_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=268d6116a40e113bad70f6e129c024254e99dae5&baseRepo=try&newRev=b9cddfec8d3baf052a687fdba333cf109fe952c5&newRepo=try&framework=1&filter\_status=improvement%2Cregression

Comment 31

[Sotaro Ikeda [:sotaro]]

Current tests results. And welcome perf test failed. Bug 1980885.

• https://perf.compare/compare-results?baseRev=59db0a19a9560df60b366cba102c075ee2948b96&baseRepo=try&newRev=3204e6bdb75c18b7b3a912b96caa1afde2f75003&newRepo=try&framework=13&filter_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=df7e16674a8c65a5335fd1adfcd6d14d34266256&baseRepo=try&newRev=5ea4b4af3cbbe7724832ece7175a66238800aa04&newRepo=try&framework=13&filter_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=7ff27047f467bf63e29cdf3e0fe6318177b88bda&baseRepo=try&newRev=8fd11fd6c10f4acc6c188b8ecd77e8b712aba443&newRepo=try&framework=13&filter_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=979e0ee76eb8bedce354b718ccdf23b8c63bc278&baseRepo=try&newRev=a7e0ce3cb38e5bb0a1a24edd49b509f7947f3552&newRepo=try&framework=1&filter_status=improvement%2Cregression

Comment 32

[Sotaro Ikeda [:sotaro]]

The performance regressions seemed to have been addressed.

• https://perf.compare/compare-results?baseRev=d765e0a3caaad85d0925456fd20c4d8571840131&baseRepo=try&newRev=7515302795dc660a3446a99a0856ca0b97f6840d&newRepo=try&framework=13&filter_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=7ec444b0cc7e838f729891b243329c1c89fcfbc3&baseRepo=try&newRev=ddb9485747d268cbf7994354ea23762b5f47ab0b&newRepo=try&framework=13&filter_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=8a1d657e646ead9ac9aa06074a891712540bd7bc&baseRepo=try&newRev=a8f6d3ee8eea28aa7b2e12b7050bbafa6efd37d0&newRepo=try&framework=13&filter_status=improvement%2Cregression

Comment 33

[Sotaro Ikeda [:sotaro]]

Hmm, talos performance was regressed :(

https://perf.compare/compare-results?baseRev=71decffd13345eed523dfbb8e1ce38847c6c01d0&baseRepo=try&newRev=7aa719775c929195c4655d446b2d649a9a339b3b&newRepo=try&framework=1&filter_status=improvement%2Cregression

Comment 34

[Sotaro Ikeda [:sotaro]]

With Bug 1984709 and Bug 1984916, talos performance regression becomes acceptable range.

• https://perf.compare/compare-results?baseRev=dbfb01134d42af3775ac2210df7a080185abf6eb&baseRepo=try&newRev=2b73355ed8a8b96ac9952852d12c1a2e963feb0c&newRepo=try&framework=1&filter_status=improvement%2Cregression

Browsertime performances were mix of improvements and regressions. They seemed to be acceptable range.

• https://perf.compare/compare-results?baseRev=51769df03e812ec009bd44d5c2d4ec61d764484d&baseRepo=try&newRev=2d4181dae3cf8b894ea62aba431053f930f3b6d1&newRepo=try&framework=13&filter_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=482c1c86ce25ceb3bc339338e4da9b3acf90931f&baseRepo=try&newRev=b904161063b32145dd8ee8ba73bcecc2214e5016&newRepo=try&framework=13&filter_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=4a1d7442dcf902493a1b41111635ba7a821c45bc&baseRepo=try&newRev=72405b3097a66e12d064735a8cde968918c71e18&newRepo=try&framework=13&filter_status=improvement%2Cregression

Comment 35

[Sotaro Ikeda [:sotaro]]

With Bug 1985197 fix, talos performance regression is acceptable range.

• https://perf.compare/compare-results?baseRev=0d40460e7116302af543d5dd76895bd8c849831c&baseRepo=try&newRev=879f107c6f87f82203ff13a709389cc3148f3a52&newRepo=try&framework=1&filter_status=improvement%2Cregression

Browsertime performances becomes good except gpu power usage.

• https://perf.compare/compare-results?baseRev=95109a9573a87f5c4efdabfad63d4f2e1dd442fd&baseRepo=try&newRev=a657288df730e3b993dc3653f81bad89df98d491&newRepo=try&framework=13&filter_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=72f8bb58e43ac7064349df6de5e0cf57766bbf24&baseRepo=try&newRev=d3bc8fe3b4c2924d0bf0c0dc3929d41e4c186c8c&newRepo=try&framework=13&filter_status=improvement%2Cregression
• https://perf.compare/compare-results?baseRev=d606f9aad267fc867a26234c0573b64d86e14a08&baseRepo=try&newRev=95d6e98dff2694ba0d6f2afd9622aadc4d5ecc18&newRepo=try&framework=13&filter_status=improvement%2Cregression

GPU power usage increase is caused by non opaque swap chain. It is going to be investigated in Bug 1987048.

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7330d24c2748
https://hg.mozilla.org/integration/autoland/rev/1f0c30406458
Enable layer compositor on Windows in Nightly r=gfx-reviewers,lsalzman,ahale

Comment 37

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1f0c30406458

Comment 38

[Donal Meehan [:dmeehan]]

:sotaro, anything you want to mention here in a release note? (Process info)
We could include it in the nightly only release notes.

Comment 39

[Sotaro Ikeda [:sotaro]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Change WebRender compositing more similar to chromium. It could affect to compositing performance.
[Affects Firefox for Android]: No
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 40

[Donal Meehan [:dmeehan]]

Will take a look

Comment 41

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx144 nightly release notes, please allow 30 minutes for the site to update.

Comment 42

[Ryan VanderMeulen [:RyanVM]]

Removed from the Nightly release notes as this has been there for 3 cycles now. Feel free to nominate again once the feature is enabled for Release.