1945776 - [wpt-sync] Sync PR 50483 - [functions] Detect cycles between local variables

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50483 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50483
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[functions] Detect cycles between local variables

This is now fairly easy to do by extending the CycleElem type
introduced in CL:6176920.

Both attributes (used by attr()) and locals need the AtomicString type;
we can distinguish between the two cases using a StrongAlias.

Note that this CL follows the behavior described in Issue 11500,
not what the spec currently says. Therefore, the test is marked
as tentative.

https://github.com/w3c/csswg-drafts/issues/11500

Bug: 325504770
Change-Id: I5a00e03175f0446a0ec6e6ba771253b4ea5f48e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6190327
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Reviewed-by: Munira Tursunova \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1415484}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5640eb19f5a6db49f0f998c4c66efdee6286943b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 11 subtests

Status Summary

Firefox

OK : 1
FAIL: 11

Chrome

OK : 1
FAIL: 11

Safari

OK : 1
FAIL: 11

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-mixins/dashed-function-cycles.tentative.html [wpt.fyi]
  • Local with self-cycle: FAIL (Chrome: FAIL, Safari: FAIL)
  • Cycle reference without fallback makes result invalid: FAIL (Chrome: FAIL, Safari: FAIL)
  • Local with self-cycle in fallback: FAIL (Chrome: FAIL, Safari: FAIL)
  • Local shadowing cyclic property --x: FAIL (Chrome: FAIL, Safari: FAIL)
  • Local shadowing cyclic outer local --x : FAIL (Chrome: FAIL, Safari: FAIL)
  • Arguments shadowing cyclic properties: FAIL (Chrome: FAIL, Safari: FAIL)
  • Observing property cycle locally: FAIL (Chrome: FAIL, Safari: FAIL)
  • Using cyclic values with no fallback: FAIL (Chrome: FAIL, Safari: FAIL)
  • Self-cycle in non-used local variable: FAIL (Chrome: FAIL, Safari: FAIL)
  • Using cyclic value in unused fallback: FAIL (Chrome: FAIL, Safari: FAIL)
  • Using cyclic value in unused fallback (local): FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35d02e6347fc
[wpt PR 50483] - [functions] Detect cycles between local variables, a=testonly
https://hg.mozilla.org/integration/autoland/rev/fa18ee42e1b1
[wpt PR 50483] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/35d02e6347fc
https://hg.mozilla.org/mozilla-central/rev/fa18ee42e1b1