1945780 - [wpt-sync] Sync PR 50484 - [functions] Substitute var() via attr() locally

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50484 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50484
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[functions] Substitute var() via attr() locally

In other words, when substituting an attribute like "var(--x)",
the referenced "--x" must respect the local context: it can either
refer to a local variable, and argument, or a custom property.

https://drafts.csswg.org/css-mixins-1/#locally-substitute-a-var

Bug: 325504770
Change-Id: I68a1d4cecc173ebe17692087edaa1014eab27466
Fixed: 391570175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6190814
Reviewed-by: Munira Tursunova \<[e-mail]>
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1415486}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac358a3d16c9c5d2bacfde4bcc6d399a8f54b3f6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
FAIL: 6

Chrome

OK : 1
FAIL: 6

Safari

OK : 1
FAIL: 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-mixins/local-attr-substitution.html [wpt.fyi]
  • var() in attribute value substitutes locally: FAIL (Chrome: FAIL, Safari: FAIL)
  • var() in attribute value substitutes locally, argument: FAIL (Chrome: FAIL, Safari: FAIL)
  • var() in attribute value substitutes locally, typed: FAIL (Chrome: FAIL, Safari: FAIL)
  • attr() fallback substitutes locally: FAIL (Chrome: FAIL, Safari: FAIL)
  • attr() cycle through local: FAIL (Chrome: FAIL, Safari: FAIL)
  • attr() cycle through fallback in local: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3836cc7f98fe
[wpt PR 50484] - [functions] Substitute var() via attr() locally, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a6ad59bd7a85
[wpt PR 50484] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3836cc7f98fe
https://hg.mozilla.org/mozilla-central/rev/a6ad59bd7a85