Closed Bug 1945797 Opened 1 year ago Closed 5 months ago

Intermittent TV browser/components/search/test/browser/browser_searchbar_context.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]

Categories

(Firefox :: Search, defect, P5)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
150 Branch
Tracking Flags:
Tracking Status
firefox150 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: florian)

References

Details

(Keywords: intermittent-failure, test-verify-fail)

Attachments

(1 file)

Bug 1945797 - Release test scope references in SearchTestUtils and SearchUITestUtils on cleanup. r=#search-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=493199263&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VMPdAiMeSTuHgSjitufwDw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VMPdAiMeSTuHgSjitufwDw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2025-02-04T12:23:00.817Z] 12:23:00     INFO - GECKO(23781) | Destroying context 7f92b5758820 surface 0 on display 7f92b4ff9200
[task 2025-02-04T12:23:01.650Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (7f92b6a06c00) [pid = 23781] [serial = 46] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2025-02-04T12:23:01.656Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (7f92b2308200) [pid = 23781] [serial = 1] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2025-02-04T12:23:01.657Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (7f928f418c00) [pid = 23781] [serial = 8] [outer = 0] [url = chrome://mochikit/content/browser-harness.xhtml]
[task 2025-02-04T12:23:01.658Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (7f929a4ba800) [pid = 23781] [serial = 3] [outer = 0] [url = chrome://extensions/content/dummy.xhtml]
[task 2025-02-04T12:23:01.658Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7f9298a14000) [pid = 23781] [serial = 6] [outer = 0] [url = about:blank]
[task 2025-02-04T12:23:01.754Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (7f92b231ac00) [pid = 23781] [serial = 5] [outer = 0] [url = chrome://extensions/content/dummy.xhtml]
[task 2025-02-04T12:23:01.755Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (7f92b5612000) [pid = 23781] [serial = 51] [outer = 0] [url = about:blank]
[task 2025-02-04T12:23:01.755Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7f928d90b000) [pid = 23781] [serial = 9] [outer = 0] [url = about:blank]
[task 2025-02-04T12:23:01.755Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7f92bfb1c800) [pid = 23781] [serial = 2] [outer = 0] [url = about:blank]
[task 2025-02-04T12:23:01.756Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7f9283fa5400) [pid = 23781] [serial = 47] [outer = 0] [url = about:blank]
[task 2025-02-04T12:23:01.774Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:406
[task 2025-02-04T12:23:01.775Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:506
[task 2025-02-04T12:23:01.776Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:406
[task 2025-02-04T12:23:01.777Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:506
[task 2025-02-04T12:23:01.777Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:406
[task 2025-02-04T12:23:01.778Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:506
[task 2025-02-04T12:23:01.779Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:406
[task 2025-02-04T12:23:01.779Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:506
[task 2025-02-04T12:23:01.780Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:406
[task 2025-02-04T12:23:01.780Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:506
[task 2025-02-04T12:23:01.781Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_SUCCESS_VOID(rv) failed with result 0x8000FFFF (NS_ERROR_UNEXPECTED): file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:406
[task 2025-02-04T12:23:01.782Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, Main Thread] WARNING: NS_ENSURE_TRUE(!!svc) failed: file /builds/worker/checkouts/gecko/dom/file/uri/BlobURLProtocolHandler.cpp:506
[task 2025-02-04T12:23:01.824Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, IPC I/O Parent] WARNING: process 23960 is a zombie: file /builds/worker/checkouts/gecko/ipc/chromium/src/base/process_util_posix.cc:250
[task 2025-02-04T12:23:01.825Z] 12:23:01     INFO - GECKO(23781) | [Parent 23781, IPC I/O Parent] WARNING: process 23880 is a zombie: file /builds/worker/checkouts/gecko/ipc/chromium/src/base/process_util_posix.cc:250
[task 2025-02-04T12:23:01.846Z] 12:23:01     INFO - TEST-INFO | Main app process: exit 0
[task 2025-02-04T12:23:01.848Z] 12:23:01     INFO - TEST-INFO | Confirming we saw 83 DOCSHELL created and 83 destroyed log strings.
[task 2025-02-04T12:23:01.849Z] 12:23:01     INFO - TEST-INFO | Confirming we saw 218 DOMWINDOW created and 218 destroyed log strings.
[task 2025-02-04T12:23:01.849Z] 12:23:01     INFO - TEST-INFO | browser/components/search/test/browser/browser_searchbar_context.js | windows(s) leaked: [pid = 23781] [serial = 46], [pid = 23781] [serial = 47]
[task 2025-02-04T12:23:01.850Z] 12:23:01     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/browser_searchbar_context.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]
[task 2025-02-04T12:23:01.850Z] 12:23:01     INFO - TEST-INFO 
[task 2025-02-04T12:23:01.850Z] 12:23:01     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/browser_searchbar_context.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2025-02-04T12:23:01.850Z] 12:23:01     INFO - TEST-INFO 
[task 2025-02-04T12:23:01.850Z] 12:23:01     INFO - runtests.py | Application ran for: 0:00:53.766127
[task 2025-02-04T12:23:01.851Z] 12:23:01     INFO - zombiecheck | Reading PID log: /tmp/tmp_sbyl8pbpidlog
[task 2025-02-04T12:23:01.851Z] 12:23:01     INFO - ==> process 23781 launched child process 23855
[task 2025-02-04T12:23:01.851Z] 12:23:01     INFO - zombiecheck | Checking for orphan process with PID: 23855
[task 2025-02-04T12:23:01.851Z] 12:23:01     INFO - Stopping web server
[task 2025-02-04T12:23:01.856Z] 12:23:01     INFO - Server shut down.
[task 2025-02-04T12:23:01.856Z] 12:23:01     INFO - Web server killed.
[task 2025-02-04T12:23:01.856Z] 12:23:01     INFO - Stopping web socket server
[task 2025-02-04T12:23:01.856Z] 12:23:01     INFO - Stopping ssltunnel
[task 2025-02-04T12:23:01.859Z] 12:23:01     INFO - Stopping gst for v4l2loopback
[task 2025-02-04T12:23:01.859Z] 12:23:01     INFO - leakcheck | Processing log file /tmp/tmpqf07pmv9.mozrunner/runtests_leaks.log for scope browser/components/search/test/browser/browser.toml
[task 2025-02-04T12:23:01.860Z] 12:23:01     INFO - TEST-INFO | leakcheck | default process: leak threshold set at 0 bytes
[task 2025-02-04T12:23:01.860Z] 12:23:01     INFO - TEST-INFO | leakcheck | tab process: leak threshold set at 0 bytes
[task 2025-02-04T12:23:01.861Z] 12:23:01     INFO - TEST-INFO | leakcheck | gmplugin process: leak threshold set at 20000 bytes
[task 2025-02-04T12:23:01.861Z] 12:23:01     INFO - TEST-INFO | leakcheck | gpu process: leak threshold set at 0 bytes
[task 2025-02-04T12:23:01.861Z] 12:23:01     INFO - TEST-INFO | leakcheck | vr process: leak threshold set at 0 bytes
[task 2025-02-04T12:23:01.862Z] 12:23:01     INFO - TEST-INFO | leakcheck | rdd process: leak threshold set at 0 bytes
[task 2025-02-04T12:23:01.862Z] 12:23:01     INFO - TEST-INFO | leakcheck | socket process: leak threshold set at 0 bytes
[task 2025-02-04T12:23:01.862Z] 12:23:01     INFO - TEST-INFO | leakcheck | forkserver process: leak threshold set at 0 bytes
[task 2025-02-04T12:23:01.862Z] 12:23:01     INFO - TEST-INFO | leakcheck | utility process: leak threshold set at 0 bytes
[task 2025-02-04T12:23:01.862Z] 12:23:01     INFO - leakcheck | Processing leak log file /tmp/tmpqf07pmv9.mozrunner/runtests_leaks_tab_pid23982.log
[task 2025-02-04T12:23:01.863Z] 12:23:01     INFO - TEST-PASS | leakcheck | tab no leaks detected!
Assignee: nobody → florian
Status: NEW → ASSIGNED

SearchTestUtils and SearchUITestUtils are module-level singletons that store a reference to the test scope in init() but never release it. Since ES module singletons persist for the lifetime of the module loader, this keeps the entire test lexical environment alive after the test finishes, which retains references to closed windows.

The fix nulls out #testScope in the cleanup function registered during init().

Blocks: mochitest-standalone
Pushed by fqueze@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/be9d47c3ddac https://hg.mozilla.org/integration/autoland/rev/071ae4eeadd2 Release test scope references in SearchTestUtils and SearchUITestUtils on cleanup. r=search-reviewers,scunnane

https://hg.mozilla.org/mozilla-central/rev/071ae4eeadd2

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox150: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
QA Whiteboard: [search] [qa-triage-done-c150/b149]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: