[wpt-sync] Sync PR 50499 - Revert "Use IDL enums for all CanvasTextDrawingStyles in Canvas2D"
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox137 fixed)
Tracking | Status | |
---|---|---|
firefox137 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 50499 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/50499
Details from upstream follow.
Andres Ricardo Perez <andresrperez@chromium.org> wrote:
Revert "Use IDL enums for all CanvasTextDrawingStyles in Canvas2D"
This reverts commit 66ceeef1ee9be8a1da3899f6d7df6045689fbe2a.
Reason for revert: LUCI Bisection has identified this change as the culprit of a build failure. See comment in the original CL.
Original change's description:
Use IDL enums for all CanvasTextDrawingStyles in Canvas2D
Some of the canvas properties that are part of CanvasTextDrawingStyles
(https://html.spec.whatwg.org/#canvastextdrawingstyles) had been
modified to use enums defined from the IDL definition of the rendering
context (fontStretch and textRendering).This CL creates enums for the rest of the CanvasTextDrawingStyles
properties. Getters and setters had to be modified, as well as a unit
test. Generated tests for setting and getting this properties already
exist in WPT, as defined in text.yaml.Bug: 341213359
Change-Id: Ic8c30219a039c96cfd83dd078157d9fb60565e03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000733
Commit-Queue: Andres Ricardo Perez \<andresrperez@chromium.org>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Jean-Philippe Gravel \<jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1415577}Bug: 341213359
Change-Id: I7038cb4140c23d014bda22e5969d798d45a038e1Reviewed-on: https://chromium-review.googlesource.com/6226570
WPT-Export-Revision: 00d3295c7c17b8e9a40db24c21a049b0917c2f0d
Assignee | ||
Comment 1•19 days ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 3 tests
Status Summary
Firefox
PASS
: 3
Chrome
PASS
: 3
Safari
PASS
: 3
Links
Comment 3•17 days ago
|
||
bugherder |
Description
•