1945999 - Make Suggest initialization happen in one place

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

This is the first step toward fixing bug 1937250.

Right now, Suggest initialization is split over two different functions:

1. UrlbarPrefs.updateFirefoxSuggestScenario() initializes the default Suggest "scenario", meaning the default values of a handful of prefs.
2. QuickSuggest.init() initializes all the various sub-features of Suggest.

Both of these functions are called by BrowserGlue, first 1 and then 2.

We can move 1 into 2 so that BrowserGlue only needs to call QuickSuggest.init().

There are no other callers of updateFirefoxSuggestScenario() other than tests.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1945999 - Make Suggest initialization happen in one place.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/015d5fd1c79f
Make Suggest initialization happen in one place. r=daisuke

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/015d5fd1c79f