1946006 - C/C++ source files compiled through Rust don't get LTO/PGO flags

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Erich Gubler [:ErichDonGubler]]

From my own DMs with :glandium:

well, cc 1.2.9 botched CFLAGS handling...

or rather, they added something that breaks our builds

funnily enough, it's stuff that should have been there in the first place

For reference, the cc 1.2.9 release notes can be found at the cc-v1.2.9 release page.

This appears to be directed at cc-rs`#1363.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1946006 - Pass PGO and LTO flags when compiling C/C++ sources from rust.

This depends on bug 1945694 for all the relevant flags to make it to the
compiler, but works even before that lands, which is fortunate because
landing bug 1945694 fail without this change.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3334fc93af8
Pass PGO and LTO flags when compiling C/C++ sources from rust. r=firefox-build-system-reviewers,sergesanspaille

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d3334fc93af8