Closed Bug 1946225 Opened 1 month ago Closed 1 month ago

Remove newline characters when sanitizing URLs

Categories

(Fenix :: QR, enhancement)

Product:
Fenix
Component:
QR
Platform:
All
Android
Type:
enhancement

Tracking

(firefox135 verified, firefox136 verified, firefox137 verified)

Status:
VERIFIED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox135 --- verified
firefox136 --- verified
firefox137 --- verified

People

(Reporter: royang, Assigned: royang)

References

Details

(Whiteboard: [fxdroid][group3])

Attachments

(1 file)

Bug 1946225 - Remove newline character when sanitizing URLs.
48 bytes, text/x-phabricator-request
dmeehan
: approval-mozilla-beta+
RyanVM
: approval-mozilla-release+
Details | Review

Add removal of newline characters when sanitizing a URL.

Whiteboard: [fxdroid][group3]
Summary: Remove new line char when sanitizing URLs → Remove newline char when sanitizing URLs
Summary: Remove newline char when sanitizing URLs → Remove newline characters when sanitizing URLs
Pushed by royang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5fb99c43562 Remove newline character when sanitizing URLs. r=android-reviewers,skhan,npoon

https://hg.mozilla.org/mozilla-central/rev/d5fb99c43562

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox137: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

Comment on attachment 9464216 [details]
Bug 1946225 - Remove newline character when sanitizing URLs.

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Without this fix, the QR reader will not represent the URL correctly.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This only affects QR reader and how URL is represented by the QR code is interpreted.
  • String changes made/needed: None
  • Is Android affected?: Yes
Attachment #9464216 - Flags: approval-mozilla-release?
Attachment #9464216 - Flags: approval-mozilla-beta?

Comment on attachment 9464216 [details]
Bug 1946225 - Remove newline character when sanitizing URLs.

Approved for 136.0b6

Attachment #9464216 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9464216 [details]
Bug 1946225 - Remove newline character when sanitizing URLs.

Approved for 135.0.1

Attachment #9464216 - Flags: approval-mozilla-release? → approval-mozilla-release+

Made a regression check with a few websites accessed through QR code on the latest builds:

  • Nightly 137.0a1 from 2025-02-17;
  • Beta 136.0b6;
  • RC 135.0.1.

No issues were found.

Device used: Google Pixel 9 Pro XL (Android 15).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: