1946433 - [contextual-password-manager] "Close Without Saving?" prompt appears when no changes are made

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P3)

Description

[Ina Popescu, Desktop QA]

Found in

• Nightly 137.0a1

Affected versions

• Nightly 137.0a1

Tested platforms

• Affected platforms: Windows 11, macOS 13 ARM, Ubuntu 22.04
• Unaffected platforms: none

Preconditions:

• Set pref browser.contextual-password-manager.enabled to true in about:config
• Enable Sidebar
• Have several saved password records

Steps to reproduce

1. Select an existing record and click Edit
2. Do not make any changes to the record
3. Click on "Cancel" button

Expected result

• The "Close without saving?" prompt should only appear when actual changes have been made to the record.

Actual result

• The "Close without saving?" prompt appears even if no changes were made.

Regression range

• N/A

Additional notes

• Please see the screen recording.

Comment 1

[Rebecca]

Not a blocker for alpha Fx138

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1946433 - Do not show "Close Without Saving" prompt when no changes are made r=mtigley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b8c442260a93
https://hg.mozilla.org/integration/autoland/rev/92b36594512d
Do not show "Close Without Saving" prompt when no changes are made r=mtigley,credential-management-reviewers

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/92b36594512d

Comment 6

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed using Firefox Nightly 141.0a1 (2025-06-12) on macOS 13, Windows 11 and Ubuntu 22.04. The "Close without saving?" prompt no longer appears when no changes were made.