Closed Bug 1946446 Opened 1 year ago Closed 1 year ago

Update about:rights

Categories

(Firefox :: Messaging System, task, P2)

task
Points:
2

Tracking

()

VERIFIED FIXED
137 Branch
Iteration:
137.2 - Feb 17 - Feb 28
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox135 --- unaffected
firefox136 + verified
firefox137 --- verified

People

(Reporter: mviar, Assigned: mviar)

References

()

Details

Attachments

(2 files)

Attachment #9465747 - Attachment description: WIP: Bug 1946446 - Update about:rights → Bug 1946446 - Update about:rights

Setting 136=fix-optional because I don't think we need to uplift this fix to Beta 136. I think it can ride the trains with 137.

Iteration: 137.1 - Feb 3 - Feb 14 → 137.2 - Feb 17 - Feb 28
Pushed by mviar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ed60896a0bd Update about:rights r=geckoview-reviewers,desktop-theme-reviewers,fluent-reviewers,dao,flod,m_kato,sessionstore-reviewers,Gijs,nsharpley
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

Meg, we'll want to uplift your about:rights changes to Beta 136, if possible. The authors of the ToS blog post would like to mention about:rights as an easy way for readers to read the ToS.

Severity: -- → N/A
Flags: needinfo?(mviar)

[Tracking Requested - why for this release]: Per, :cpeterson's comment above, the authors of the TOS blog post would like to mention about:rights as an easy way for readers to read the TOS. The timing for this would require the change to be present in Fx136 release.

Flags: needinfo?(mviar)

Not sure about the tracking request on this instead of seeing an uplfit request?
This touches a few areas, are there string changes, risks, etc.

  • Redirect about:rights to terms page
    • Remove code related to old in-tree about:rights page

[[ https://mozilla-hub.atlassian.net/browse/FIDE-2485 | See Jira ticket ]]

Original Revision: https://phabricator.services.mozilla.com/D237913

Attachment #9467250 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: A blog post going out next Tuesday will mention about:rights and that it will lead to our new terms of service, if this doesn't go out with 136 this could lead to some confusion
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: Ensure about:rights redirects to new terms marketing page
  • Risk associated with taking this patch: Low
  • Explanation of risk level: This was reviewed by a number of stakeholders and manual testing is straightforward, we're just redirecting users to a different website when they visit about:rights
  • String changes made/needed: no
  • Is Android affected?: no
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
Attachment #9467250 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Flags: needinfo?(mviar)

:mviar, I added a comment on the beta phab revision but mentioning here also.
There are conflicts with beta, please rebase and update the patch.

Thanks for flagging, I've rebased and update the patch.

Flags: needinfo?(mviar)
Attachment #9467250 - Flags: approval-mozilla-beta- → approval-mozilla-beta+
QA Contact: tzsoldos

I have reproduced this issue using Firefox 137.0a1 (2025.02.06) on Ubuntu 22.
I can confirm this issue is fixed, I verified using Firefox 139.0a1, Firefox 136.0.4, Firefox 137.0.2 and Firefox 138.0 on Ubuntu 22, Windows 11 and on macOS 10.15.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged] → [qa-triaged][qa-ver-done-c140/b139]
Flags: qe-verify+
See Also: → 2030386
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: