1946501 - ScreenCaptureKit.framework should be a weak_framework

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Pier Angelo Vendrame]

Bug 1914196 added -framework ScreenCaptureKit.
However, older versions of macOS do not support that framework, so it should be a -weak_framework instead (see also the original build file).

Firefox official builds already link it weakly (LC_LOAD_WEAK_DYLIB in otool -l), but some configurations don't (we had this problem downstream with Tor Browser, where we use lld instead of ld64 and we disable WebRTC).

Comment 1

[Pier Angelo Vendrame]

Attachment: Bug 1946501 - Make ScreenCaptureKit a weak framework. r?#build,#webrtc-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1914196

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb4eebfbb001
Make ScreenCaptureKit a weak framework. r=webrtc-reviewers,pehrsons

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/eb4eebfbb001

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pierov, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Pier Angelo Vendrame]

I'm setting wontfix for beta, as Firefox production builds seem not to be affected.
However, I'd like this to be uplifted to ESR.
Thanks!

Comment 7

[Manuel Bucher [:manuel]]

Attachment: Bug 1946501 - Make ScreenCaptureKit a weak framework. r?#build,#webrtc-reviewers

Original Revision: https://phabricator.services.mozilla.com/D237085

Comment 8

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Unofficial Firefox builds that exclude webrtc crash on startup on macos. Downstream users who with that configuration would need to backport the fix on their own.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Explanation of risk level: Not user facing. Only changes build system. Mostly useful for downstream.
• String changes made/needed: no
• Is Android affected?: no

Comment 9

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1946501 - Make ScreenCaptureKit a weak framework. r?#build,#webrtc-reviewers

Original Revision: https://phabricator.services.mozilla.com/D237085

Comment 10

[Andreas Pehrson [:pehrsons]]

Sorry, missed that an uplift request had already been made when looking at https://phabricator.services.mozilla.com/D237085#8200641.